rbutilqt: Replace insecure sprintf() with snprintf()
rockbox-gerrit-noreply--- via rockbox-cvs <[email protected]> Mon, 29 Jun 2026 17:41:19 -0400
| Newsgroups | gmane.comp.systems.archos.rockbox.cvs |
|---|---|
| Message-ID | <[email protected]> |
commit cf2872af11b15b7a7d379815a273150fa8123397 Author: Vencislav Atanasov <[email protected]> Date: Mon Jun 29 21:56:14 2026 +0300 rbutilqt: Replace insecure sprintf() with snprintf() Co-authored-by: ChatGPT (GPT-5.3 Mini) <[email protected]> Change-Id: Ic2abe417f17a6f104cc4523b155ca6fdb5965bb1 diff --git a/utils/rbutilqt/base/bootloaderinstallipod.cpp b/utils/rbutilqt/base/bootloaderinstallipod.cpp index 4673119d85..1e5b1c39b2 100644 --- a/utils/rbutilqt/base/bootloaderinstallipod.cpp +++ b/utils/rbutilqt/base/bootloaderinstallipod.cpp @@ -242,12 +242,12 @@ bool BootloaderInstallIpod::ipodInitialize(struct ipod_t *ipod) return false; } #if defined(Q_OS_WIN32) - sprintf(ipod->diskname, "\\\\.\\PhysicalDrive%i", devicename.toInt()); + snprintf(ipod->diskname, sizeof(ipod->diskname), "\\\\.\\PhysicalDrive%i", devicename.toInt()); #elif defined(Q_OS_MACOS) - sprintf(ipod->diskname, "%s", + snprintf(ipod->diskname, sizeof(ipod->diskname), "%s", qPrintable(devicename.remove(QRegularExpression("s[0-9]+$")))); #else - sprintf(ipod->diskname, "%s", + snprintf(ipod->diskname, sizeof(ipod->diskname), "%s", qPrintable(devicename.remove(QRegularExpression("[0-9]+$")))); #endif LOG_INFO() << "ipodpatcher: overriding scan, using" diff --git a/utils/rbutilqt/base/bootloaderinstallsansa.cpp b/utils/rbutilqt/base/bootloaderinstallsansa.cpp index 41c2e615ca..d2c17113e8 100644 --- a/utils/rbutilqt/base/bootloaderinstallsansa.cpp +++ b/utils/rbutilqt/base/bootloaderinstallsansa.cpp @@ -245,12 +245,13 @@ bool BootloaderInstallSansa::sansaInitialize(struct sansa_t *sansa) return false; } #if defined(Q_OS_WIN32) - sprintf(sansa->diskname, "\\\\.\\PhysicalDrive%i", devicename.toInt()); + snprintf(sansa->diskname, sizeof(sansa->diskname), + "\\\\.\\PhysicalDrive%i", devicename.toInt()); #elif defined(Q_OS_MACOS) - sprintf(sansa->diskname, + snprintf(sansa->diskname, sizeof(sansa->diskname), "%s", qPrintable(devicename.remove(QRegularExpression("s[0-9]+$")))); #else - sprintf(sansa->diskname, + snprintf(sansa->diskname, sizeof(sansa->diskname), "%s", qPrintable(devicename.remove(QRegularExpression("[0-9]+$")))); #endif LOG_INFO() << "sansapatcher: overriding scan, using" -- rockbox-cvs mailing list [email protected] https://lists.haxx.se/mailman/listinfo/rockbox-cvs