rbutil: Fix some compile warnings under Windows
rockbox-gerrit-noreply--- via rockbox-cvs <[email protected]> Sat, 4 Jul 2026 11:14:06 -0400
| Newsgroups | gmane.comp.systems.archos.rockbox.cvs |
|---|---|
| Message-ID | <[email protected]> |
commit 9a31255ff8ce2deff2ce0859bd364418f7f84bab Author: Solomon Peachy <[email protected]> Date: Sat Jul 4 11:13:34 2026 -0400 rbutil: Fix some compile warnings under Windows Change-Id: I8abfbd61066c17297962de1432144692604cf245 diff --git a/utils/rbutilqt/base/system.cpp b/utils/rbutilqt/base/system.cpp index 0ab0d9823a..672e9464cb 100644 --- a/utils/rbutilqt/base/system.cpp +++ b/utils/rbutilqt/base/system.cpp @@ -28,8 +28,10 @@ // Windows Includes #if defined(Q_OS_WIN32) #if defined(UNICODE) +#ifndef _UNICODE #define _UNICODE #endif +#endif #include <windows.h> #include <tchar.h> #include <lm.h> @@ -489,5 +491,3 @@ QUrl System::systemProxy(void) return QUrl(""); #endif } - - diff --git a/utils/rbutilqt/base/utils.cpp b/utils/rbutilqt/base/utils.cpp index ef0c11ca83..92e09de569 100644 --- a/utils/rbutilqt/base/utils.cpp +++ b/utils/rbutilqt/base/utils.cpp @@ -587,7 +587,7 @@ QStringList Utils::mountpoints(enum MountpointsFilter type) for(int i=0; i<list.size();i++) { wchar_t t[32]; - memset(t, 0, 32); + memset(t, 0, sizeof(t)); if(GetVolumeInformationW((LPCWSTR)list.at(i).absolutePath().utf16(), NULL, 0, NULL, NULL, NULL, t, 32) == 0) { // on error empty retrieved type -- don't rely on diff --git a/utils/rbutilqt/configure.cpp b/utils/rbutilqt/configure.cpp index 25cea94acf..7b6d634c3f 100644 --- a/utils/rbutilqt/configure.cpp +++ b/utils/rbutilqt/configure.cpp @@ -39,8 +39,10 @@ #include "comboboxviewdelegate.h" #if defined(Q_OS_WIN32) #if defined(UNICODE) +#ifndef _UNICODE #define _UNICODE #endif +#endif #include <tchar.h> #include <windows.h> #endif -- rockbox-cvs mailing list [email protected] https://lists.haxx.se/mailman/listinfo/rockbox-cvs