quickscreen: update SBS after each button press

rockbox-gerrit-noreply--- via rockbox-cvs <[email protected]>
Newsgroups gmane.comp.systems.archos.rockbox.cvs
Message-ID <[email protected]>
commit 8cfa4bfd8cd596a48d2afea441f297f2519008fd
Author: Christian Soffke <[email protected]>
Date:   Sun Aug 16 15:18:04 2026 +0200

    quickscreen: update SBS after each button press
    
    Quickscreen will ignore update_delay so that the SBS
    is updated after each button press, without any lag.
    
    The SBS may display settings that are adjusted by the
    Quickscreen (e.g. cabbiev2's Shuffle and Repeat icons,
    or the brightness slider included in themes like
    Adwaitapod and Themify).
    
    Change-Id: I28716e81cb77e235eb009bff91c96f510365f435

diff --git a/apps/gui/quickscreen.c b/apps/gui/quickscreen.c
index 535ba23409..af42df6e65 100644
--- a/apps/gui/quickscreen.c
+++ b/apps/gui/quickscreen.c
@@ -416,14 +416,10 @@ static void quickscreen_run(struct quickscreen * qs)
         }
         else if (button == qs->button_enter)
             can_quit = true;
-        else if (button == ACTION_QS_VOLUP) {
+        else if (button == ACTION_QS_VOLUP)
             adjust_volume(1);
-            sb_skin_force_next_update();
-        }
-        else if (button == ACTION_QS_VOLDOWN) {
+        else if (button == ACTION_QS_VOLDOWN)
             adjust_volume(-1);
-            sb_skin_force_next_update();
-        }
         else if (button == ACTION_STD_CONTEXT)
         {
             qs->result |= QUICKSCREEN_GOTO_SHORTCUTS_MENU;
@@ -434,6 +430,10 @@ static void quickscreen_run(struct quickscreen * qs)
 
         if (button == ACTION_STD_CANCEL)
             break;
+
+        /* Ignore SBS update_delay, so that setting
+           changes are immediately visible. */
+        sb_skin_force_next_update();
     }
     /* Notify that we're exiting this screen */
     cond_talk_ids_fq(VOICE_OK);
-- 
rockbox-cvs mailing list
[email protected]
https://lists.haxx.se/mailman/listinfo/rockbox-cvs
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.