[patch #8638] Remove non-ASCII Characters-in Comments

Moritz Klammler <[email protected]>
Newsgroups gmane.comp.sysutils.autoconf.archive-maintainers
Message-ID <[email protected]>
URL:
  <http://savannah.gnu.org/patch/?8638>

                 Summary: Remove non-ASCII Characters-in Comments
                 Project: GNU Autoconf Archive
            Submitted by: moritz_klammler
            Submitted on: Sat 04 Apr 2015 04:29:58 AM CEST
                Priority: 5 - Normal
                  Status: None
             Assigned to: None
        Originator Email: 
             Open/Closed: Open
         Discussion Lock: Any

    _______________________________________________________

Details:

The files `m4/ax_compiler_flags.m4`, `m4/ax_compiler_flags_cflags.m4`,
`m4/ax_compiler_flags_cxxflags.m4` and `m4/ax_compiler_flags_ldflags.m4`
contained non-ASCII characters that caused (at least if using Python 3) the
`macro2m4.py` script that is run as part of `make maintainer-all` to fail.

Since all offensive characters were apostrophes in comments, I simply replaced
them with ASCII 39 characters.  This fixes the immediate issue.  I assume that
ASCII encoding was deliberately chosen for maximum portability.  Otherwise, it
might be preferred to modify the Python script to use UTF-8 encoding thus
allowing such characters.

I have also attached a little Python script that can be used to check whether
a file contains non-ASCII characters.  I've run it over all `m4/*.m4` files
and it did not report any other issues.




    _______________________________________________________

File Attachments:


-------------------------------------------------------
Date: Sat 04 Apr 2015 04:29:58 AM CEST  Name:
0001-Removed-non-ASCII-characters-in-comments.patch  Size: 5kB   By:
moritz_klammler

<http://savannah.gnu.org/patch/download.php?file_id=33525>
-------------------------------------------------------
Date: Sat 04 Apr 2015 04:29:58 AM CEST  Name: bad-characters.py  Size: 633B  
By: moritz_klammler

<http://savannah.gnu.org/patch/download.php?file_id=33526>

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/patch/?8638>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.