Re: Valgrind check: No rule to make target 'check-TESTS'

Philip Withnall <[email protected]> Mon, 01 Aug 2016 15:02:05 +0100

Newsgroups	gmane.comp.sysutils.autoconf.archive-maintainers
Organization	Collabora
Message-ID	<[email protected]>

On Mon, 2016-08-01 at 15:26 +0200, Sébastien Wilmet wrote:
> Hello,
> 
> I would like to use ax_valgrind_check.m4, but I have the following
> error:
> 
> $ make check-valgrind-memcheck 
> make check-TESTS \
>         TESTS_ENVIRONMENT=" env VALGRIND=valgrind G_SLICE=always-
> malloc,debug-blocks G_DEBUG=fatal-warnings,fatal-criticals,gc-
> friendly" \
>         LOG_COMPILER="/bin/sh ./libtool   --mode=execute valgrind  
> --error-exitcode=1 --num-callers=30" \
>         LOG_FLAGS="--tool=memcheck --leak-check=full --show-
> reachable=no" \
>         TEST_SUITE_LOG=test-suite-memcheck.log
> make[1]: Entering directory '/home/seb/gnome/gspell'
> make[1]: *** No rule to make target 'check-TESTS'.  Stop.
> make[1]: Leaving directory '/home/seb/gnome/gspell'
> Makefile:1220: recipe for target 'check-valgrind-memcheck' failed
> make: *** [check-valgrind-memcheck] Error 2
> 
> 
> There is no check-TESTS target in the project that I maintain, here
> gspell. See its testsuite/Makefile.am:
> https://git.gnome.org/browse/gspell/tree/testsuite/Makefile.am?h=1.1.
> 2
> 
> It's basically using:
> noinst_PROGRAMS = $(UNIT_TEST_PROGS)
> TESTS = $(UNIT_TEST_PROGS)
> UNIT_TEST_PROGS = ...
> 
> So, is this a bug in ax_valgrind_check.m4? Or does it make some
> assumptions that are not applied in gspell?

I suspect you have added @VALGRIND_CHECK_RULES@ to
$top_srcdir/Makefile.am, and are running `make check-valgrind-memcheck` 
there. What you need to do instead is to add @VALGRIND_CHECK_RULES@ to
$top_srcdir/testsuite/Makefile.am, and run `make -C testsuite check-
valgrind-memcheck`.

check-TESTS should be defined in $top_builddir/testsuite/Makefile.in,
but not in $top_builddir/Makefile.in, since you don’t have any tests
defined there.

Philip

signature.asc (application/pgp-signature, 819 B)