Re: remove _DARWIN_USE_64_BIT_INODE
Paul Eggert <[email protected]>
| Newsgroups | gmane.comp.sysutils.autoconf.bugs |
|---|---|
| Organization | UCLA Computer Science Department |
| Message-ID | <[email protected]> |
Thanks, I installed the attached and have merged the first patch into Gnulib; the second patch merges the code with Gnulib.
0001-Remove-definition-of-_DARWIN_USE_64_BIT_INODE.patch
(text/x-patch, 1.1 KB)
From 8f582a83efca19d3bd4ae30197a4c3aa155ce84c Mon Sep 17 00:00:00 2001 From: Paul Eggert <[email protected]> Date: Fri, 21 Feb 2020 17:17:45 -0800 Subject: [PATCH 1/2] Remove definition of _DARWIN_USE_64_BIT_INODE MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit It’s not needed in currently-supported macOS versions, and was problematic anyway in MacOS X 10.5 which was the only version that could use it. Problem reported by Peter Eisentraut in: https://lists.gnu.org/r/bug-autoconf/2020-02/msg00004.html * lib/autoconf/specific.m4 (AC_SYS_LARGEFILE): Don’t define _DARWIN_USE_64_BIT_INODE. --- lib/autoconf/specific.m4 | 3 --- 1 file changed, 3 deletions(-) diff --git a/lib/autoconf/specific.m4 b/lib/autoconf/specific.m4 index 4dec075b..1c41832d 100644 --- a/lib/autoconf/specific.m4 +++ b/lib/autoconf/specific.m4 @@ -168,9 +168,6 @@ if test "$enable_largefile" != no; then [Define for large files, on AIX-style hosts.], [_AC_SYS_LARGEFILE_TEST_INCLUDES]) fi - - AC_DEFINE([_DARWIN_USE_64_BIT_INODE], [1], - [Enable large inode numbers on Mac OS X 10.5.]) fi ])# AC_SYS_LARGEFILE -- 2.24.1
0002-Mention-32-bit-GNU-Linux-64-bit-inodes.patch
(text/x-patch, 1.1 KB)
From aa0f42b332852f3e39fa0aa08f2530ec4386c36c Mon Sep 17 00:00:00 2001 From: Paul Eggert <[email protected]> Date: Fri, 21 Feb 2020 17:23:10 -0800 Subject: [PATCH 2/2] Mention 32-bit GNU/Linux 64-bit inodes * lib/autoconf/specific.m4 (AC_SYS_LARGEFILE): In a comment, mention 64-bit inode problem on 32-bit GNU/Linux. This is taken from Gnulib. --- lib/autoconf/specific.m4 | 3 +++ 1 file changed, 3 insertions(+) diff --git a/lib/autoconf/specific.m4 b/lib/autoconf/specific.m4 index 1c41832d..2809c009 100644 --- a/lib/autoconf/specific.m4 +++ b/lib/autoconf/specific.m4 @@ -132,6 +132,9 @@ rm -rf conftest*[]dnl # one must use special compiler options to get large-file access to work. # For more details about this brain damage please see: # http://www.unix.org/version2/whatsnew/lfs20mar.html +# Additionally, on Linux file systems with 64-bit inodes a file that happens +# to have a 64-bit inode number cannot be accessed by 32-bit applications on +# Linux x86/x86_64. This can occur with file systems such as XFS and NFS. AC_DEFUN([AC_SYS_LARGEFILE], [AC_ARG_ENABLE(largefile, [ --disable-largefile omit support for large files]) -- 2.24.1