Re: [PATCH 2/6] AC_CHECK_HEADER/AC_CHECK_HEADERS: complete transition to compile tests.

On 09/13/2013 06:42 PM, Zack Weinberg wrote:
> * lib/autoconf/headers.m4 (AC_CHECK_HEADER): Use _AC_CHECK_HEADER_COMPILE
>   by default.  Continue to use _AC_CHECK_HEADER_PREPROC if fourth arg is '-'.
>   (_AC_CHECK_HEADER_PREPROC): Issue a deprecation warning.
>   (_AC_CHECK_HEADER_MONGREL, _AC_CHECK_HEADER_MONGREL_BODY): Remove.
> 
> * tests/c.at, tests/semantics.at: Update uses of AC_CHECK_HEADER(S).
> * doc/autoconf.texi, NEWS: Document change.
> 
> Signed-off-by: Zack Weinberg <[email protected]>
> ---

>  
> +# _AC_CHECK_HEADER_MONGREL(HEADER-FILE,
> +#			   [ACTION-IF-FOUND], [ACTION-IF-NOT-FOUND])
> +# ------------------------------------------------------------------
> +# In case anyone used this undocumented macro.  Map to the _PREPROC
> +# semantics to minimize the chance of breaking anything.

Well, in 2.69, the mongrel code favored compile results, not preproc.
But as this is undocumented, and as the preproc variant outputs a
warning, the users deserve a warning for using undocumented macros.  I
agree with the decision.

ACK.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.14 (GNU/Linux)
Comment: Public key at http://people.redhat.com/eblake/eblake.gpg
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQEcBAEBCAAGBQJSPZRGAAoJEKeha0olJ0NqntAIAIscfqScRKgFXgY7FxFHOp9q
vlly1TAHgX1o0HlMbMa4zgv8W0WuNV21SVfWW9//ZZvv8fU+XSd3tf6BgvTFIPXh
d63an2QXwqlsy9xktzMSa9KSbkABYJRHCxdvVXwgDZut5cLOChbr1/+uI1PxVUat
fNU8/rfBdIL0gZsrzHrF9k6/ADf8evCS792UGTR1mCORgBMQFHstpq6U/VuH/fTO
JRVQuzNw2xYt9Pr77wXafh59HVCiZBRmKggGeOjJoNMKYZrvGYsn8AR1yTohBgy5
/MioYydLYyrGFH38YSAp1PYT+h/n4moZvtQB0uObJkkc9VgjHiVipGpHXqZxYrw=
=vnr2
-----END PGP SIGNATURE-----