Re: [PATCH 3/6] Modernize AC_INCLUDES_DEFAULT and friends.

Eric Blake <[email protected]>
Newsgroups gmane.comp.sysutils.autoconf.patches
Organization Red Hat, Inc.
Message-ID <[email protected]>
On 09/21/2013 06:05 PM, Zack Weinberg wrote:
> On Sat, Sep 21, 2013 at 9:29 AM, Eric Blake <[email protected]> wrote:
>> On 09/14/2013 10:22 AM, Zack Weinberg wrote:
> ...
>>>    (AC_HEADER_STDC, AC_UNISTD_H): AU_DEFUN to trigger
>>>    _AC_INCLUDES_DEFAULT_REQUIREMENTS if it hasn't already happened,
>>>    and do nothing else.
> ...
>> Ah, I see what you did - you expanded to ac_dummy="AC_INCLUDES_DEFAULT"
>> rather than actually spelling out the internal macro name - it triggers
>> the internal macro via AC_REQUIRES magic.  Interesting :)
> 
> Right.  (In case you're wondering, the AS_IF is to ensure that the
> AC_REQUIRE expansion happens before the beginning of the
> ac_dummy="..." statement.)
> 
> Given that, do you still want patch 6?

Yes, patch 6 is still worthwhile.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc (application/pgp-signature, 621 B)
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.14 (GNU/Linux)
Comment: Public key at http://people.redhat.com/eblake/eblake.gpg
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQEcBAEBCAAGBQJSQEW1AAoJEKeha0olJ0NqpzIH/1aeuUwbaXMvyevZXqYUkdGV
vz7EbGFmWLfJMQzKR+8/LTpOQbaS1KWenxVsuWEl6M5GVpDTguZ2SLR1UAiYnHQ2
pEdD9zIZ4dxGeARadZYxSj3aVukzVhJT0lVNQVWsgSFqpv6F1hIl4OaF4KFQXM4N
yKJb64EZe1QlBol295y/GjyaY7x4fOw9m+c2rcfkGRZRIrM1Mgf/cTTEaLi5pRmK
9ncZAC2itu0i5cgFzYkga/4aqaewaVBaqT8ryHOraVeIWL/ls3Ykq5zCSkw9WWUb
WIKHnKLMCOVQQbZKuJAzcUBKhUWFJeQPbxnx1/RnsAWQlT6+hS3vhRzPmqY5vDY=
=NLVG
-----END PGP SIGNATURE-----
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.