Re: [PATCH 3/4] _AS_LN_S_PREPARE: default to 'cp -pR' on OS/2

Eric Blake <[email protected]> Mon, 22 Sep 2014 09:41:53 -0600

Newsgroups	gmane.comp.sysutils.autoconf.patches
Organization	Red Hat, Inc.
Message-ID	<[email protected]>

On 09/22/2014 12:59 AM, KO Myung-Hun wrote:
> On OS/2, any others than kLIBC have no symlinks.

Any other what?  Do you mean:

On OS/2, only kLIBC provides symlinks, and not all executables link with
kLIBC

?  Or something else?

> 
> * lib/m4sugar/m4sh.m4 (_AS_LN_S_PREPARE): Subject.
> ---
>  lib/m4sugar/m4sh.m4 |    9 +++++----
>  1 files changed, 5 insertions(+), 4 deletions(-)
> 
> diff --git a/lib/m4sugar/m4sh.m4 b/lib/m4sugar/m4sh.m4
> index a94999e..8f6d184 100644
> --- a/lib/m4sugar/m4sh.m4
> +++ b/lib/m4sugar/m4sh.m4
> @@ -1189,12 +1189,13 @@ fi
>  if (echo >conf$$.file) 2>/dev/null; then
>    if ln -s conf$$.file conf$$ 2>/dev/null; then
>      as_ln_s='ln -s'
> -    # ... but there are two gotchas:
> +    # ... but there are three gotchas:
>      # 1) On MSYS, both `ln -s file dir' and `ln file dir' fail.
>      # 2) DJGPP < 2.04 has no symlinks; `ln -s' creates a wrapper executable.
> -    # In both cases, we have to default to `cp -pR'.
> -    ln -s conf$$.file conf$$.dir 2>/dev/null && test ! -f conf$$.exe ||
> -      as_ln_s='cp -pR'
> +    # 3) On OS/2, any others than kLIBC has no symlinks.
> +    # In three cases, we have to default to `cp -pR'.
> +    ln -s conf$$.file conf$$.dir 2>/dev/null && test ! -f conf$$.exe &&
> +      test -z "$OS2_SHELL" || as_ln_s='cp -pR'

Is the goal here to unconditionally use 'cp -pR' if OS2_SHELL is set?

>    elif ln conf$$.file conf$$ 2>/dev/null; then
>      as_ln_s=ln
>    else
> 

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc (application/pgp-signature, 539 B)