Re: [PATCH 1/4] AC_CACHE_SAVE: treat x: as an absolute path as well

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi/2.

Eric Blake wrote:
> On 09/22/2014 12:59 AM, KO Myung-Hun wrote:
>> * lib/autoconf/general.m4 (AC_CACHE_SAVE): Subject.
> 
> That's a poor changelog entry.  Better might be:
> 
> AC_CACHE_SAVE: treat x: as an absolute path as well
> 
> * lib/autoconf/general.m4 (AC_CACHE_SAVE): Treat raw drive as 
> absolute for OS/2 and mingw.
> 
>> --- lib/autoconf/general.m4 |    2 +- 1 files changed, 1
>> insertions(+), 1 deletions(-)
>> 
>> diff --git a/lib/autoconf/general.m4 b/lib/autoconf/general.m4 
>> index 59d204f..77f71d2 100644 --- a/lib/autoconf/general.m4 +++
>> b/lib/autoconf/general.m4 @@ -942,7 +942,7 @@ do esac # Be sure
>> to have absolute directory names. case $ac_val in -    [[\\/$]]*
>> | ?:[[\\/]]* )  continue;; +    [[\\/$]]* | ?:[[\\/]]* | ?: )
>> continue;;
> 
> On mingw, 'c:' is not necessarily absolute; Windows has up to 27
> current working directories (the current working directory when no
> drive letter is given, and then one current directory for each
> drive), so 'c:foo' could mean 'c:/path/to/foo' instead of 'c:/foo'.
> I'm not sure how it works on OS/2.  I also don't know the rationale
> for your change - how often do you actually encounter someone using
> AC_CACHE_SAVE with a raw drive letter and no path as the
> destination?  That is, you don't try to ever save the cache as
> 'c:', but as 'c:/file', in which case the pattern already matches.
> Without an example of something that is broken without this patch,
> I'm less inclined to apply it.
> 

These are old codes used by OS/2 fork for a long time. I just
preserved them. But I'm not sure the real problem occurs. So I'll
submit this patch later if I find an example breaking autoconf.

Thanks.

- -- 
KO Myung-Hun

Using Mozilla SeaMonkey 2.7.2
Under OS/2 Warp 4 for Korean with FixPak #15
In VirtualBox v4.1.32 on Intel Core i7-3615QM 2.30GHz with 8GB RAM

Korean OS/2 User Community : http://www.ecomstation.co.kr

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (OS/2)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iD8DBQFUINkuE9YstvghgroRAvMdAJ9Bz11RncbE3rpBwOcO5kPh898zXwCggCIH
XyUCbIp3ovIKflHhOW8q8j0=
=UaFu
-----END PGP SIGNATURE-----