Re: [PATCH 2/4] AC_PROG_LEX: Rephrase LEX is set test
Eric Blake <[email protected]>
| Newsgroups | gmane.comp.sysutils.autoconf.patches |
|---|---|
| Organization | Red Hat, Inc. |
| Message-ID | <[email protected]> |
On 04/09/2015 06:43 AM, Bernhard Reutner-Fischer wrote: > 2015-04-08 Bernhard Reutner-Fischer <[email protected]> > > * lib/autoconf/programs.m4 (AC_PROG_LEX): Rephrase LEX is set > test. > > Signed-off-by: Bernhard Reutner-Fischer <[email protected]> > --- > lib/autoconf/programs.m4 | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/autoconf/programs.m4 b/lib/autoconf/programs.m4 > index 931177b..abf554c 100644 > --- a/lib/autoconf/programs.m4 > +++ b/lib/autoconf/programs.m4 > @@ -709,7 +709,7 @@ AN_PROGRAM([lex], [AC_PROG_LEX]) > AN_PROGRAM([flex], [AC_PROG_LEX]) > AC_DEFUN_ONCE([AC_PROG_LEX], > [AC_CHECK_PROGS(LEX, flex lex, :) > -if test "x$LEX" != "x:"; then > +if [[ ${LEX:+y} ]]; then NACK. This is checking if $LEX is specifically something other than ':', not whether it is empty. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
(application/pgp-signature, 604 B)
-----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJVJnzLAAoJEKeha0olJ0NqslcH/2z9Qz/uTVSnkKNCbd8j/ICe +m7yR21DfSKYk+FWxEEs9NMli/xBJeS0Y3R2VG6L0usWSJj3Za3Wmjlc95qsqWRg 1dc/MNpSN0is2lv2qPKDJEXCMyz7G9AjBR3LJIYPYVLAFnHKiP0VWaCyZTl9pHMA cGYaHeScReY/ZkI/36QoA3Lt3BpuKi9ZlzyPxgbF8up8l2hib6Z+soTq41ifCE6M rf4oIAMVsiKwB2aGAncgYLgINNlHuQM2Mm/XKJhT0p9DOCJaalOrn8Gcol6KHJb+ HQFhSaxQTGZ3LqTc0jMGV4xVs+0PRfHn4UlcxiEvgYJkY5FPYOBL6DDsE3Cswpo= =u5V/ -----END PGP SIGNATURE-----