Re: [PATCH] m4_set_foreach: pop macro definition

Eric Blake <[email protected]>
Newsgroups gmane.comp.sysutils.autoconf.patches
Organization Red Hat, Inc.
Message-ID <[email protected]>
On 04/20/2015 07:16 PM, Nick Bowler wrote:

> Turns out the implementation already had a pushdef, and it looks like
> the popdef was simply forgotten.  Add it now.

Thanks for catching that.

>  m4_define([m4_set_foreach],
> -[m4_pushdef([$2])m4_set_map_sep([$1], [m4_define([$2],], [)$3])])
> +[m4_pushdef([$2])m4_set_map_sep([$1], [m4_define([$2],], [)$3])dnl
> +m4_popdef([$2])])

I'm going to push a followup that avoids a 'dnl' in the middle of the
macro. With 'dnl' right there, ALL expansions have to further go through
one more macro expansion.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc (application/pgp-signature, 604 B)
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
Comment: Public key at http://people.redhat.com/eblake/eblake.gpg
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQEcBAEBCAAGBQJVNjw7AAoJEKeha0olJ0NqEhEH/jagkvObwHl9lTiCITXD1CJ3
XA2Ys7zPqBpKQ0bnbRkiY5BMULR8lC5msHQ9iFGxdMVaUEpkpYB8VBN2ismKHG9P
Jblydpgass/bbZXgevQJGOvupkXXKz8L/YJIEY1SgrczUbo8FCRmpsXC7hsdbJRY
oqtHHAutU/6F3eFGrET3N517m7yutJOSlDaiX4TKFsLJZ3fGds7WESko9IaoYQVl
Re6ITbhcoIMCcR3yG42IZ9bt6x4/Db5Cem8lU1Nj+FOyyG47YOkRmDQF/fU25ZRK
f6BqQT/h4vPERZlfqr37+kd9npl1NU2Vj+I+g0pm8jmmp3QawCNpPdzKPtpMAO4=
=uqX6
-----END PGP SIGNATURE-----
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.