Re: [PATCH 2/2] AC_SITE_LOAD: append '.exe' to ac_executable_extensions on OS/2
Eric Blake <[email protected]>
| Newsgroups | gmane.comp.sysutils.autoconf.patches |
|---|---|
| Organization | Red Hat, Inc. |
| Message-ID | <[email protected]> |
On 05/28/2015 11:43 PM, KO Myung-Hun wrote: > Codes searching for the executables uses '' and > $ac_executable_extensions as extensions of the executables. But it is > used without any initializing. That is, it is an empty string by > default. As a result, without appending '.exe' to it on OS/2, > searching for the executables fails on OS/2. > > * lib/autoconf/general.m4 (AC_SITE_LOAD): Append '.exe' to > ac_executable_extensions if it does not contain '.exe' on OS/2. Weird. The code adding support for $ac_executable_extensions has been present since 2001, but nothing has ever set it. That pre-dates my involvement with autoconf, so I'm not sure of the rationale. There was definitely some work done for OS/2 at the time (https://lists.gnu.org/archive/html/autoconf-patches/2001-09/msg00134.html for example), but I'm not finding good rationale for the patch as committed. Oh, searching a bit further found this: https://lists.gnu.org/archive/html/autoconf-patches/2001-06/msg00041.html which mentions that ac_executable_extensions should be set by config.site. So again, I'm not sure you need this patch (which would only help for packages that have been built with new autoconf) when you can instead tweak your config.site (and work with all existing packages). I will, however, accept a patch to the manual to document ac_executable_extensions, and that it is the user's responsibility to set it to a sane value in config.site if they are on a platform where .exe (or .bat or ...) is required. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
(application/pgp-signature, 604 B)
-----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJVaGRzAAoJEKeha0olJ0Nq2RoH/R3ZIchxWEr3+OJcn0563WXy uECVnZ4lJgLH1WKhFsi/FxNcsam1DFIyCOTdiM8cvdW7h0GCkxuqNU4QoV2/OEIL D9HMka4ZL7TEE4sedYcCQcKemBnMjNV0f7I7xTe7Shy3NUEpL2A1dsGe+b+dqdCJ awWRHqGjulZimQFB1E7jynv+x/VsipnMQieRkU5pyI4xsr+ltbFLiH8fm9a9KiSF wTcw6/3e9Y6wGNOJAZmcbD8Ek56r5RpGKqouDSO3tdwgKgqvN3ypSORDVgAWKBMo bB/z2fEwob2peHLg5g0OCpeNaqVBNKKMOFWTbeeKoN+0K/EA6gb8PHun3KHtclw= =zZlS -----END PGP SIGNATURE-----