Re: [PATCH 1/3] autoconf: prefer an unrolled loop for trivial AC_CHECK_FUNCS

Eric Blake <[email protected]>
Newsgroups gmane.comp.sysutils.autoconf.patches
Organization Red Hat, Inc.
Message-ID <[email protected]>
On 10/31/2016 06:39 AM, Paolo Bonzini wrote:
> An unrolled loop avoids the cost of spawning sed in AS_TR_SH and
> AS_TR_CPP.  Prefer it if there is nothing in the second and third
> argument of AC_CHECK_FUNCS and the first argument is a literal.
> Modify AC_CHECK_FUNCS_ONCE to avoid the variable indirection too.
> 
> * lib/autoconf/functions.m4 (AC_CHECK_FUNCS): Unroll loop if safe.
> (_AC_CHECK_FUNCS): Move basic implementation here.
> (_AC_CHECK_FUNC_ONCE): Expand AC_CHECK_FUNCS here...
> (_AC_FUNCS_EXPANSION): ... and not here, so remove.
> 
> Signed-off-by: Paolo Bonzini <[email protected]>
> ---
>  lib/autoconf/functions.m4 | 25 +++++++++++--------------
>  1 file changed, 11 insertions(+), 14 deletions(-)

ACK

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc (application/pgp-signature, 604 B)
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
Comment: Public key at http://people.redhat.com/eblake/eblake.gpg
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQEcBAEBCAAGBQJYF2LAAAoJEKeha0olJ0NqcokIAKv5g55BtbFjhfGahpIJiBCA
/FcuoJNaNnSL8tNWWrAt54XnxsO7njCihlZi+FQBq566hPael3c4Psa1j7Z5bRhU
0DaSt4osqjWyCD9ZhTa+/doq0q2LISJvkqkamS/bIUl8h7K01absXJ5jsiDTCN8u
tWDE50UrmLzlGJHp14kDaZH+tvGTfy+umyqHbbTXgZsUr8hth4PveigIIclw+2fm
LQeeIKlhRZ2PGenB8bt0UTn/yNWkW/hMyq6cFqgcR4YM4yW7rdrGRpwA7d41eV9R
VNQij1NRGi+qOiyILKDCVg5FRjLQFxIr4QFHOj4O1GENTVk4loO6hEHe8sPJyWk=
=jqgm
-----END PGP SIGNATURE-----
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.