Re: [PATCH] Support for Flang and ARM HPC compiler
Paul Osmialowski <[email protected]>
| Newsgroups | gmane.comp.sysutils.autoconf.patches |
|---|---|
| Message-ID | <[email protected]> |
On 08/30/17 14:28, Paul Osmialowski wrote: > Hi Eric, > > Thanks for your reply. > > I've received "Undelivered Mail Returned to Sender" immediately after > sending this one. Therefore I've sent it once again, this time with the > right "From:" line. > > Also I've sent autoconf patch to this list by mistake, please ignore it. Ok, sending things to four different lists during one single morning ends like that. The line above was about accitently sent autoconf patch to the gnulib list :) > > On 08/30/17 14:19, Eric Blake wrote: >> On 08/30/2017 06:55 AM, [email protected] wrote: >>> From: root <[email protected]> >> >> Looks like you failed to properly configure your git. >> >>> -m4_define([_AC_F95_FC], [gfortran g95 xlf95 f95 fort ifort ifc efc >>> pgfortran pgf95 lf95 ftn nagfor]) >>> +# flang: LLVM Fortran compiler >>> +# armflang: ARM HPC Fortran compiler >>> +m4_define([_AC_F95_FC], [gfortran g95 xlf95 f95 fort ifort ifc efc >>> armflang flang pgfortran pgf95 lf95 ftn nagfor]) >> >> It would be nice to wrap this to avoid a long line in the source, but >> that's minor. >> >> I'm not a fortran expert, so I can't test this, but in principle the >> patch looks reasonable; and it is small enough to not need copyright >> assignment. However, I wonder if it does need mention in NEWS, so I'll >> wait a bit longer before applying to see if anyone else chimes in on >> review. >> >