Re: [PATCH] doc: clarify integer requirements in some functions

Mike Frysinger <[email protected]> Sat, 12 Feb 2022 04:03:47 -0500
Newsgroups gmane.comp.sysutils.autoconf.patches
Message-ID <Ygd385OFT1jW0usQ@vapier>
On 12 Feb 2022 00:35, Paul Eggert wrote:
> On 2/12/22 00:28, Mike Frysinger wrote:
> > These functions do not accept decimal values with fractional parts.
> > Describe them in terms of integers to clarify.
> 
> I dunno, those values all must be integers by their nature so saying 
> "integer" in the doc doesn't help much; conversely, if the doc omits the 
> word "decimal" people might think the numbers could be octal or hex.

perhaps one can argue that for the help description macros if we assume anyone
working on this code is fully versed in terminal output behavior, but i don't
think you can argue that for the min/max functions, nor for the arith ones.  i
don't think, based on the description of AS_VAR_ARITH, this is unreasonable:
  blah=2
  AS_VAR_ARITH([foo], [$blah + 0.1])
-mike
signature.asc (application/pgp-signature, 833 B)
-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEuQK1JxMl+JKsJRrUQWM7n+g39YEFAmIHd/MACgkQQWM7n+g3
9YHXcg/9FTfqfHkBaWnOdwY0HlHipzw6T7zrQ0Ysf7LkOlr+bpYs40b6nlz2h4g8
4gnEk8tVDEmQ3BcdZPWGxyEveHpKtzFFFG87jj/E3kHVxY1GU6ED3V207at5Bls2
RJI9iZSeNoztlPhH2fMGXo2LXkKXGK2jhLIOWMirCkD94zvGJOQ6Gof/wR0g/bAn
8cvt3E47sC1A/brNmq/PV/uYlVXdRSFIH4/TX+usuxojKyl4HC45L26JwToa2atb
tne7fzyknvVMzWtvAOpIqoxptJAA4DhcyffL3m7QovmLFrQXMGEhgqD/lkSLvZq+
+1M3Goe5jcT2F2oADLntgZdz/t7PyJfCSP+9npvYsRKftAp6AvPMMaodyevG7GZR
kY28bTVKGcKzq50dS85qIX1IIuPTgfh/oU+SC3liWJtPYemzI5v5BKXUaruxP8rC
ppuySOXKxTjiyzFTxWWIDW7PXvKREZNKekkh1aETPVSzFlxk+/ViLncfR1KQtF53
Z3/uuQ6LsFQs4xvTwkYippG2hOP/NTHq75QKozUzTgMtrlY7NoW3copb2k1tzFMh
a6lqLY9S2QUUren2aES9uclYWt0HIL3ntQVCjOfcJvldzMzokoG0MI0WTpwo6CpL
McuuR+QoU4Uj/vSnYsYL6tzFWXrU34mYW7cdKbpiqm4WE5R/LCY=
=seRN
-----END PGP SIGNATURE-----