Re: [PATCH v2] specify void prototype for functions with no parameters

Sam James <[email protected]> Mon, 19 Sep 2022 03:56:10 +0100

Newsgroups	gmane.comp.sysutils.autoconf.patches
Message-ID	<[email protected]>

> On 30 Aug 2022, at 22:53, Paul Eggert <[email protected]> wrote:
> 
> On 8/29/22 21:35, Khem Raj wrote:
>> Compilers defaulting to C99 flag such functions as warning which fails
>> to compile when using -Werror
> 
> As mentioned earlier, projects should not use -Werror when configuring, for several reasons (this is just one). After you mentioned rsync was using something like -Werror I sent in a patch to the rsync folks, and rsync has been fixed:
> 
> https://github.com/WayneD/rsync/commit/9a3449a3980421f84ac55498ba565bc112b20d6c
> 
> What other projects are doing it? They should be fixed too, regardless of whether we change Autoconf here.
> 
> As for Autoconf, if we're going to make this change at all, we should do it fully. Something like the attached patch, perhaps. I haven't installed it.
> <0001-Port-to-compilers-that-moan-about-K-R-func-decls.patch>

In order to help with the rather mass breakage with newer Clang, could the autoconf
maintainers consider a small new release with this fix?

We're dealing with a rather large number in Gentoo (https://bugs.gentoo.org/870412)
and a non-trivial number are in configure scripts (including some which aren't
reported yet because, by their nature, they aren't always explicit failures).

See also https://discourse.llvm.org/t/configure-script-breakage-with-the-new-werror-implicit-function-declaration/65213.

Best,
sam

signature.asc (application/pgp-signature, 358 B)