Re: [PATCH 1/2] Fix detection of GNU M4 on mksh

Hi/2.

Zack Weinberg wrote:
> On Sun, Oct 15, 2023, at 2:58 AM, KO Myung-Hun wrote:
>> Zack Weinberg wrote:
>>> On Sat, Oct 14, 2023, at 9:19 AM, KO Myung-Hun wrote:
>>>> * m4/m4.m4 (AC_PROG_GNU_M4): Double-quotes $ac_snip2.
>>> Please explain why it isn't also necessary to add double quotes
>>> around all the other variable expansions in this check, particularly
>>> $ac_snippet and $ac_path_M4.
>>
>> Because this test fails due to $ac_snip2
> 
> Details please?
> 

Commit message was not enough ?

$ac_snip2 contains NL. And in order to print it, `print -r --' command
is used on mksh.

BTW, printing without double-quoting, NL in $ac_snip2 is replaced with a
space. Because of this, M4 does not return contents expected. As a
result, test for $ac_snip2 fails.

-- 
KO Myung-Hun

Korean OS/2 User Community : https://www.os2.kr/