Re: [PATCH] Add quotes in AS_IF test for gid_t

This is a multi-part message in MIME format.
--------------E5NEkfo07FfZXRqx6DlmdUz4
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

On 2/6/24 20:37, Nick Bowler wrote:
> On 2024-02-06 22:33, Sam James wrote:
>> Noticed when building Emacs:
>> ```
>> * checking type of array argument to getgroups... ./configure: 42782: test: =: unexpected operator
>> ```

> Oh look, I see this line in emacs-29.2/configure.ac:
> 
>    AC_DEFUN([AC_TYPE_UID_T])
> 
> This is the actual cause of the problem, because AC_TYPE_UID_T is the
> part of Autoconf that would have assigned this variable.  Since Emacs
> has deleted its definition, it has therefore broken other Autoconf
> macros (like AC_TYPE_GETGROUPS) which depend on it.

Thanks for reporting this. I installed the attached patch into Emacs master.

The now-fixed bug in Emacs's generated 'configure' script should be 
harmless on all platforms I know about, as AC_TYPE_GETGROUPS should go 
ahead and do the right thing anyway.

PS. There is a case for quoting all uses of ac_cv_* variables, as their 
values may be corrupted in the cache. This is my usual style elsewhere 
and perhaps Autoconf should adopt it. Of course if we'd done that we 
would likely never have spotted this harmless error in Emacs 
configure.ac....
--------------E5NEkfo07FfZXRqx6DlmdUz4
Content-Type: text/x-patch; charset=UTF-8;
 name="0001-Port-better-to-Autoconf-2.72.patch"
Content-Disposition: attachment;
 filename="0001-Port-better-to-Autoconf-2.72.patch"
Content-Transfer-Encoding: base64

RnJvbSBlMzRlYmMwY2NjNmMyN2U3ZTEyMTdiYWFkOWNhNzRkZDdiZWE0YzM3IE1vbiBTZXAg
MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBQYXVsIEVnZ2VydCA8ZWdnZXJ0QGNzLnVjbGEuZWR1
PgpEYXRlOiBXZWQsIDcgRmViIDIwMjQgMTM6MTc6NTcgLTA4MDAKU3ViamVjdDogW1BBVENI
XSBQb3J0IGJldHRlciB0byBBdXRvY29uZiAyLjcyCgoqIGNvbmZpZ3VyZS5hYzogU2V0IGFj
X2N2X3R5cGVfZ2lkX3Q9eWVzIHRvIHBhY2lmeSBBdXRvY29uZiAyLjcyCkFDX1RZUEVfR0VU
R1JPVVBTLiAgUHJvYmxlbSByZXBvcnRlZCBieSBOaWNrIEJvd2xlciBpbjoKaHR0cHM6Ly9s
aXN0cy5nbnUub3JnL3IvYXV0b2NvbmYtcGF0Y2hlcy8yMDI0LTAyL21zZzAwMDAxLmh0bWwK
LS0tCiBjb25maWd1cmUuYWMgfCAxICsKIDEgZmlsZSBjaGFuZ2VkLCAxIGluc2VydGlvbigr
KQoKZGlmZiAtLWdpdCBhL2NvbmZpZ3VyZS5hYyBiL2NvbmZpZ3VyZS5hYwppbmRleCBiNzRl
YmE4NzlhYi4uODQ3ZmRiZDU0ZDIgMTAwNjQ0Ci0tLSBhL2NvbmZpZ3VyZS5hYworKysgYi9j
b25maWd1cmUuYWMKQEAgLTIzMzcsNiArMjMzNyw3IEBAIEFDX0RFRlVOCiBBQ19ERUZVTihb
QUNfVFlQRV9TSVpFX1RdKQogIyBMaWtld2lzZSBmb3Igb2Jzb2xlc2NlbnQgdGVzdCBmb3Ig
dWlkX3QsIGdpZF90OyBFbWFjcyBhc3N1bWVzIHRoZW0uCiBBQ19ERUZVTihbQUNfVFlQRV9V
SURfVF0pCithY19jdl90eXBlX2dpZF90PXllcyAjIEFDX1RZUEVfR0VUR1JPVVBTIG5lZWRz
IHRoaXMgaW4gQXV0b2NvbmYgMi43Mi4KIAogIyBDaGVjayBmb3IgYWxsIG1hdGguaCBmdW5j
dGlvbnMgdGhhdCBFbWFjcyB1c2VzOyBvbiBzb21lIHBsYXRmb3JtcywKICMgLWxtIGlzIG5l
ZWRlZCBmb3Igc29tZSBvZiB0aGVzZSBmdW5jdGlvbnMuCi0tIAoyLjQzLjAKCg==

--------------E5NEkfo07FfZXRqx6DlmdUz4--