Re: [PATCH] Fix autoreconf -fvi failure on OS/2

Paul Eggert <[email protected]> Sun, 9 Feb 2025 10:22:40 -0800
Newsgroups gmane.comp.sysutils.autoconf.patches
Organization UCLA Computer Science Department
Message-ID <[email protected]>
This is a multi-part message in MIME format.
--------------oAr2RzMBnQcikFIH0ba9Su1l
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

On 2025-02-08 19:07, KO Myung-Hun wrote:
> OS/2 does not allow file actions with a file name to opened files. As a
> result, copy(), chmod() and update_file() fail.

Ouch, that means OS/2 is inherently insecure with temp files due to 
races in some situations. However, the Autoconf code is already insecure 
even on non-OS/2 platforms, so I guess it's no extra harm done.


> +      copy ($src, $^O eq 'os2' ? $temp : $tempname)

I'd rather not have os2-specific code if we can avoid it, as that makes 
testing harder cross-platform. I installed the attached instead; please 
give it a try.

--------------oAr2RzMBnQcikFIH0ba9Su1l
Content-Type: text/x-patch; charset=UTF-8;
 name="0001-Port-install_aux_file-to-OS-2.patch"
Content-Disposition: attachment;
 filename="0001-Port-install_aux_file-to-OS-2.patch"
Content-Transfer-Encoding: base64

RnJvbSAyZjY0ZGNkMDQ4YjA4YmI5MGVjNDRiMjZmNGNkNmI3MjkxMTJhMjhlIE1vbiBTZXAg
MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBQYXVsIEVnZ2VydCA8ZWdnZXJ0QGNzLnVjbGEuZWR1
PgpEYXRlOiBTdW4sIDkgRmViIDIwMjUgMTA6MDA6MTEgLTA4MDAKU3ViamVjdDogW1BBVENI
XSBQb3J0IGluc3RhbGxfYXV4X2ZpbGUgdG8gT1MvMgoKKiBiaW4vYXV0b3JlY29uZi5pbiAo
aW5zdGFsbF9hdXhfZmlsZSk6IFBvcnQgdG8gT1MvMiwKd2hpY2ggZG9lcyBub3QgYWxsb3cg
ZmlsZSBuYW1lIG9wZXJhdGlvbnMgb24gb3BlbiBmaWxlcy4KUHJvYmxlbSByZXBvcnRlZCBi
eSBLTyBNeXVuZy1IdW4gaW46Cmh0dHBzOi8vbGlzdHMuZ251Lm9yZy9yL2F1dG9jb25mLXBh
dGNoZXMvMjAyNS0wMi9tc2cwMDAwMS5odG1sCi0tLQogYmluL2F1dG9yZWNvbmYuaW4gfCA0
ICsrKy0KIDEgZmlsZSBjaGFuZ2VkLCAzIGluc2VydGlvbnMoKyksIDEgZGVsZXRpb24oLSkK
CmRpZmYgLS1naXQgYS9iaW4vYXV0b3JlY29uZi5pbiBiL2Jpbi9hdXRvcmVjb25mLmluCmlu
ZGV4IDc0Yzk4OTBlLi5hNWZmYzZmYSAxMDA2NDQKLS0tIGEvYmluL2F1dG9yZWNvbmYuaW4K
KysrIGIvYmluL2F1dG9yZWNvbmYuaW4KQEAgLTQwMCw4ICs0MDAsMTAgQEAgc3ViIGluc3Rh
bGxfYXV4X2ZpbGUKICAgICAgICAgICAgIG9yIGZhdGFsICJybSAtZiAkZGVzdDogJCEiOwog
ICAgICAgICB9CiAgICAgICBteSAoJHRlbXAsICR0ZW1wbmFtZSkgPSB0ZW1wZmlsZSAoVU5M
SU5LID0+IDAsIERJUiA9PiAkZGVzdGRpcik7Ci0gICAgICBjb3B5ICgkc3JjLCAkdGVtcG5h
bWUpCisgICAgICBjb3B5ICgkc3JjLCAkdGVtcCkKICAgICAgICAgb3IgZmF0YWwgImNvcHlp
bmcgJHNyYyB0byAkdGVtcG5hbWU6ICQhIjsKKyAgICAgIGNsb3NlICgkdGVtcCkKKyAgICAg
ICAgb3IgZmF0YWwgImNsb3NpbmcgJHRlbXBuYW1lOiAkISI7CiAgICAgICBtYWtlX2V4ZWN1
dGFibGUgKCR0ZW1wbmFtZSkgaWYgLXggJHNyYzsKICAgICAgIHVwZGF0ZV9maWxlICgkdGVt
cG5hbWUsICRkZXN0LCAkZm9yY2UpOwogICAgIH0KLS0gCjIuNDUuMgoK

--------------oAr2RzMBnQcikFIH0ba9Su1l--