Re: Avoid -Wtrailing-whitespace in config.h.
"Zack Weinberg" <[email protected]> Sat, 04 Oct 2025 08:59:35 -0400
| Newsgroups | gmane.comp.sysutils.autoconf.patches |
|---|---|
| Message-ID | <[email protected]> |
On Sat, Oct 4, 2025, at 2:03 AM, Collin Funk wrote: > This patch changes config.status to write the following in config.h: > > #define TRAILING_WHITESPACE /**/ > > When the following lines are in configure.ac: > > trailing_whitespace= > AC_DEFINE_UNQUOTED([TRAILING_WHITESPACE], [$trailing_whitespace], > [trailing whitespace]) > > Previously it would have trailing whitespace instead of /**/ causing > annoying GCC warnings. Thanks for the patch; however, the awk logic needs to handle arbitrary sequences of spaces and tabs, not just a single space. (It can map them all to " /**/"; we're generating a C #define directive, so we know that all nonempty sequences of spaces and tabs are equivalent in context.) Please also add a test case. zw