Re: [PATCH 1/2] python: Properly uninstall __pycache__ in subdirectories

On Sat, 07 Jul 2018 at 23:43:28, Mathieu Lirzin wrote:
> Lukas Fleischer <[email protected]> writes:
> 
> > When uninstalling __pycache__ files in a subdirectory "sub", the
> > Makefile incorrectly removed the files from __pycache__/sub/ instead of
> > sub/__pycache__/.
> >
> > * lib/am/python.am (uninstall-%DIR%PYTHON): Use the correct path when
> > installing byte-compiled files installed in '__pycache__'
> > subdirectories.
> 
> Tell me if I am overlooking something, but I guess this change will
> imply that the uninstallation does not properly work with older python
> version?  Have you tried?

I don't think so. My guess is that uninstalling __pycache__ from
subdirectories has always been broken --- unless there has been a
behavioral change in recent Python releases that affects the location of
__pycache__ in strange ways.

When running the test suite with Python 2, everything still works (which
is not surprising given that __pycache__ was only introduced in Python
3.2).

Unfortunately, when I run nobase-python.sh with Python 3.4, that test
fails both with and without the patch applied, so it is hard to tell
whether __pycache__ handling is broken with that Python release.

Regards,
Lukas