Re: [PATCH] dejagnu: add support for silent builds with site.exp

Mike Frysinger <[email protected]> Wed, 17 Nov 2021 19:40:36 -0500

Newsgroups	gmane.comp.sysutils.automake.patches
Message-ID	<YZWhBKtQ2DJpTf2R@vapier>

On 17 Nov 2021 14:22, Karl Berry wrote:
> Thanks for the patch, Mike.
> 
>     * lib/am/dejagnu.am (site.exp): Use $(AM_V_GEN) 
> 
> Ok. Can you tell me how to discern that this makes a difference?
> Is there some test where it can be observed?
> I've never actually used dejagnu with Automake. 

i don't know of an easy way to produce a distilled testcase.
i'm using the gdb/binutils project to check behavior.
https://sourceware.org/git/?p=binutils-gdb.git;a=summary

after you configure+make, you can iterate with just `make site.exp`.

>     and merge all independent shell calls into one.
> 
> Is something gained by doing so? I actually find it more readable to
> avoid long \-continued shell commands in Automake wherever
> possible. (Admittedly there are already zillions of places where there
> is no way to avoid it.  Indeed, IMHO those constructs are the single
> hardest-to-debug aspect of Automake.) --thanks, karl.

doesn't make spawn a shell for every line ?  so instead of running bash
like 18 times, we run it just once.

the goal was to simplify the $(AM_V_GEN) logic.  i guess you could replace
the first @ with $(AM_V_GEN) and every subsequent @ with $(AM_V_at) instead.
-mike

signature.asc (application/pgp-signature, 833 B)