Re: PATCH: silence Shellcheck warning
Mike Frysinger <[email protected]>
| Newsgroups | gmane.comp.sysutils.automake.patches |
|---|---|
| Message-ID | <YeaF/CIf0icJJ3k7@vapier> |
On 22 Jul 2018 14:41, Nick Bowler wrote: > On 7/21/18, Ben Elliston <[email protected]> wrote: > > This patch silences a warning from Shellcheck about using old-style > > `...` command substitutions. > [...] > > commit 4d35c7aae97234bf055519075ef03cd4090a1dfc > > Author: Ben Elliston <[email protected]> > > Date: Sun Jul 22 08:22:44 2018 +1000 > > > > * missing: Use $(..) command substitution syntax. > > Several shells do not support $(...) substitutions so portable scripts > like 'missing' must always use backticks. I would suggest that this > linter warning is spurious if not outright counterproductive. Shellcheck is doing the right thing. it targets POSIX, not ancient shells that the vast majority people should never waste their time on. that said, automake targets lower than POSIX, so i agree that we should leave it be for automake specifically. feel like posting a patch to suppress this particular check in lib/missing instead ? -mike
signature.asc
(application/pgp-signature, 833 B)
-----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEuQK1JxMl+JKsJRrUQWM7n+g39YEFAmHmhfwACgkQQWM7n+g3 9YHiLw//ZD33MP+dZYhKnjUFLJODLEJjORTM+uf41wUNDtCfUrjoifGfxqB0wuU2 QT6FR2gh9nQ7ObNO/8zSAhk7YfOaXUuZ/UXakWDAyVQVEY8JRbURwh1fIPelbDB8 01saj8XBVGphkVmplATB6/dQQqwkceCx7B4pU7ikZcj4MBSPy3lHDOfyiPTNbEFZ A7TAu+TAQxDe1lqRJFMWHnue9sXYu4oWTN6/GY/+ud8aNmi/D1pceQrPgupydNlA P8aAHewTVnHld5Cbve3bciGMBqXqEk8P3SHkZShLFNbvnalb07nMMO7lC85BqiiJ ZtiVXOxfrFTq6sqKbYuOJLOYpyZYs4Ptwik1Ukr2fcsnnKcHB6sW3p5PjTz6Dpxe cp0tVnLEoCh255WroeLv7pUQBL/UNzd+fn784ayTYsPH1oOntzcz15SkwLVJgdKz 4o61vmvkOmTz8rTMhcmFJEWCMFHxoPclntcNZ7o4YisINYWemAfGM3chhoqJ3pXI nejUhFXrjk5SjpTG1yJNgrqEOSUa89MZJ1+8XIJb5J1UYlAgx6tg+Cl6p3q7+fYF ssitwP9mAyxAfOe6eGAAQyHd++iG0Dix9hfTAYekyxBot1lDRuflyWzIJerteTwx 2KdxBfDHiD7FE3u8b3HP/0boPqw93L0CEoeAl01p7b0GU6u1CbQ= =7CXi -----END PGP SIGNATURE-----