Re: [PATCH] PATH: use double quote

On 09/22/2014 01:12 AM, KO Myung-Hun wrote:
> * Makefile.am: Subject.

That's a very poor changelog entry.  I'll leave it up to the automake
maintainer if it should be improved, though.

> * t/Makefile.inc: Likewise.
> ---
>  Makefile.am    |    2 +-
>  t/Makefile.inc |    4 ++--
>  2 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/Makefile.am b/Makefile.am
> index 7e1c748..07c52c4 100644
> --- a/Makefile.am
> +++ b/Makefile.am
> @@ -72,7 +72,7 @@ generated_file_finalize = $(AM_V_at) \
>  # For some tests or targets, we need to have the just-build automake and
>  # aclocal scripts avaiable on PATH.
>  extend_PATH = \
> -  { PATH='$(abs_builddir)/t/wrap'$(PATH_SEPARATOR)$$PATH && export PATH; }
> +  { PATH="$(abs_builddir)/t/wrap$(PATH_SEPARATOR)$$PATH" && export PATH; }

Why are you changing this? I see no difference in the resulting shell
syntax, except that backslashes in $(abs_builddir) are now handled
differently.  You need a lot more justification for WHY this patch is
necessary.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
Comment: Public key at http://people.redhat.com/eblake/eblake.gpg

iQEcBAEBCAAGBQJUIEBnAAoJEKeha0olJ0Nq3ngH/0jINH87De/S6d8oLq6TQLlj
XAsGJBaPdfnQR6YN2P0zHYUtVOS9QY45hA7BbvM9XSd8YsYqBzN4zWGY03HHzJEz
8exUHBnJJrZGehtr1PK1a5FMVt/UoBQWfRtWWMfD/yf7HgNly+/7K2A8o+8GGM+e
LiV6lfJyLnc3svQ0UV7kLuLRKIZfaAJLNT2DIUoUhRvTbb098l4wI56alrKNJzPr
lq69VKzKemvkewiTRDEezui1SCYhTtYyEcleZPzGnPmjiVJH7Gz0X5oQfcEzn29/
VPFXmRwGjL4zLK0LmsWfJnd4bXFsPILAPdZ6DMerCS8eHV9yiYnn+GUxfL+Jgqw=
=OEIA
-----END PGP SIGNATURE-----