Re: bug#19108: bad error messages in dist targets, automake 1.14.1

Stefano Lattarini <[email protected]>
Newsgroups gmane.comp.sysutils.automake.patches
Message-ID <[email protected]>
severity 19108 minor
close 19108
thanks

On 11/19/2014 05:40 PM, Aharon Robbins wrote:
> Hi. I'm trying to upgrade to automake 1.14.1, and I see this:
>
> @@ -993,10 +993,16 @@ dist-xz: distdir
>   	$(am__post_remove_distdir)
>
>   dist-tarZ: distdir
> +	@echo WARNING: "Support for shar distribution archives is" \
> +	               "deprecated." >&2
> +	@echo WARNING: "It will be removed altogether in Automake 2.0" >&2
>   	tardir=$(distdir) && $(am__tar) | compress -c >$(distdir).tar.Z
>   	$(am__post_remove_distdir)
>
>   dist-shar: distdir
> +	@echo WARNING: "Support for distribution archives compressed with" \
> +		       "legacy program 'compress' is deprecated." >&2
> +	@echo WARNING: "It will be removed altogether in Automake 2.0" >&2
>   	shar $(distdir) | GZIP=$(GZIP_ENV) gzip -c >$(distdir).shar.gz
>   	$(am__post_remove_distdir)
>
>
> The error messages are associated with the wrong targets.
>
> I thought I reported this already...
>
> Thanks,
>
> Arnold
>
Thank for the report.  I've applied a fix that will appear in the next
automake release.
0001-dist-adjust-warning-messages-about-shar-and-tarZ-dep.patch (text/x-patch, 1.7 KB)
From 4410ae7f201a1e70da63b95680467223f77dffab Mon Sep 17 00:00:00 2001
Message-Id: <4410ae7f201a1e70da63b95680467223f77dffab.1418983893.git.stefano.lattarini@gmail.com>
From: Aharon Robbins <[email protected]>
Date: Fri, 19 Dec 2014 11:08:15 +0100
Subject: [PATCH] dist: adjust warning messages about shar and tarZ deprecation

They were swapped.  Reported in http://debbugs.gnu.org/19108.

Signed-off-by: Stefano Lattarini <[email protected]>
---
 lib/am/distdir.am | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/lib/am/distdir.am b/lib/am/distdir.am
index a8ad63c..0c01960 100644
--- a/lib/am/distdir.am
+++ b/lib/am/distdir.am
@@ -339,8 +339,8 @@ dist-xz: distdir
 ?COMPRESS?DIST_ARCHIVES += $(distdir).tar.Z
 .PHONY: dist-tarZ
 dist-tarZ: distdir
-	@echo WARNING: "Support for shar distribution archives is" \
-	               "deprecated." >&2
+	@echo WARNING: "Support for distribution archives compressed with" \
+		       "legacy program 'compress' is deprecated." >&2
 	@echo WARNING: "It will be removed altogether in Automake 2.0" >&2
 	tardir=$(distdir) && $(am__tar) | compress -c >$(distdir).tar.Z
 	$(am__post_remove_distdir)
@@ -348,9 +348,9 @@ dist-tarZ: distdir
 ?SHAR?DIST_ARCHIVES += $(distdir).shar.gz
 .PHONY: dist-shar
 dist-shar: distdir
-	@echo WARNING: "Support for distribution archives compressed with" \
-		       "legacy program 'compress' is deprecated." >&2
 	@echo WARNING: "It will be removed altogether in Automake 2.0" >&2
+	@echo WARNING: "Support for shar distribution archives is" \
+	               "deprecated." >&2
 	shar $(distdir) | GZIP=$(GZIP_ENV) gzip -c >$(distdir).shar.gz
 	$(am__post_remove_distdir)
 
-- 
2.1.3
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.