Re: [Patch] 3.1.0

Jeffrey J. Kosowsky wrote:

> Matthias Meyer wrote at about 13:04:01 +0100 on Saturday, March 12, 2011:
>  > I've implemented some changes more than a year ago.
>  > I've run the changed BackupPC within a production environment since a
>  > year. My patch contains:
>  >  - store each interrupted backup as a partial backup and makes it
>  >  possible
>  > to configure how much partials should be stored as a maximum
>  >  - make the first backup of a year as a full backup and makes it
>  >  possible to
>  > configure how much of this yearly backups can be stored
>  > 
>  > Therefore the following configuration items where be added:
>  > $Conf{FullCntYearly}
>  > $Conf{useEveryPartial}
>  > $Conf{PartialAgeMax}
>  > 
>  > See BackupPC.html for a detailed description.
> 
> Sounds great!
Thanks ;-)
> Does the patch work against 3.2.0 which is the current version and of
> course includes other good patches?
I don't now :-( I've decided to not use 3.2 for the moment. I've not enough 
time for testing.
> 
> Also, I have always wanted to have the ability to flag individual
> backups to be saved and to escape the pruning logic (if an incremental
> were so tagged then also the lower level incrementals and
> corresponding full would be saved).
> 
> The easiest way is to rename the backups so that they don't get
> detected by the deletion algorithm but then they don't show up in the
> web interface and you lose the backupinfo data.
> 
> It would be nice to have an official scheme to support this. Say, by
> adding a ".save" suffix to a backup which would tell BackupPC to still
> view it as a backup but not to delete it.
Yes, thats right.
My solution based on one configuration variable ($Conf{FullCntYearly}) and 
the corresponding code in BackupPC_dump/BackupExpire(). There are no impact 
on other parts of the code. 

For a solution covering your needs a change within the $TopDir/<pc>/backups 
file seems to be necessary.
I would believe either an additional column which mark an backup as 
undeletable or two additional types (incr.nodel, full.nodel) which do that.
However - the new flags have to be appraised in 
BackupPC_dump/BackupExpire(). Furthermore the impact of other code parts of 
this change have to be analyzed. Unfortunatley I'm not familar enough with 
the whole BackupPC code.

br
Matthias
-- 
Don't Panic


------------------------------------------------------------------------------
Colocation vs. Managed Hosting
A question and answer guide to determining the best fit
for your organization - today and in the future.
http://p.sf.net/sfu/internap-sfd2d
_______________________________________________
BackupPC-devel mailing list
[email protected]
List:    https://lists.sourceforge.net/lists/listinfo/backuppc-devel
Wiki:    http://backuppc.wiki.sourceforge.net
Project: http://backuppc.sourceforge.net/