Re: [Patch] 3.1.0

Matthias Meyer wrote at about 19:58:20 +0100 on Tuesday, March 15, 2011:
 > Jeffrey J. Kosowsky wrote:
 > 
 > > Matthias Meyer wrote at about 13:04:01 +0100 on Saturday, March 12, 2011:
 > >  > I've implemented some changes more than a year ago.
 > >  > I've run the changed BackupPC within a production environment since a
 > >  > year. My patch contains:
 > >  >  - store each interrupted backup as a partial backup and makes it
 > >  >  possible
 > >  > to configure how much partials should be stored as a maximum
 > >  >  - make the first backup of a year as a full backup and makes it
 > >  >  possible to
 > > Would it be possible to separate this into 2 independent patches?
 > > It doesn't seem like there is much overlap and personally I am much more
 > > interested in #1 than #2.
 > > 
 > Theoretically yes ;-)
 > But as Holger recommended first I have to restructuring my patch 
 > infrastructure.
 > But why do you don't use the patch as deployed and set 
 > $Conf{FullCntYearly}=0. In this case backupPC will work as before (regarding > this patch).

Because I believe that patches should be focused and streamlined.
I don't want to patch functionality that I am uninterested in changing
since that just risks introducing unintended bugs and makes other code
updates and patches potentially conflicting and/or more difficult.

------------------------------------------------------------------------------
Colocation vs. Managed Hosting
A question and answer guide to determining the best fit
for your organization - today and in the future.
http://p.sf.net/sfu/internap-sfd2d
_______________________________________________
BackupPC-devel mailing list
[email protected]
List:    https://lists.sourceforge.net/lists/listinfo/backuppc-devel
Wiki:    http://backuppc.wiki.sourceforge.net
Project: http://backuppc.sourceforge.net/