Re: FIXED Re: 11.0.0/11.0.1 badly formed expression on Solaris 11.3 with Solaris Developer Studio 12.6

Radosław Korzeniewski <[email protected]> Mon, 1 Mar 2021 12:30:37 +0100
Newsgroups gmane.comp.sysutils.backup.bacula.devel
Message-ID <CAF_EmoAOMoeXCjUY_6s-LAkW1-8aifhFnaX-4=VEkuQ7KCR5PQ@mail.gmail.com>
Hello,

pon., 1 mar 2021 o 12:16 Gary R. Schmidt <[email protected]>
napisał(a):

> On 01/03/2021 22:00, Radosław Korzeniewski wrote:
> [SNIP]
> > Bacula configure script is checking for typeof() and sets HAVE_TYPEOF if
> > found. I think the proper fix should use:
> >
> > #ifdefHAVE_TYPEOF
> > ...
> > #else
> > ...
> > #endif
>
> More correctly, autfsckup


I do not understand the word above...


> should look for typeof, __typeof, and
> __typeof__, define TYPEOF appropriately, and *then* have #ifdef TYPEOF.
>

If someone could write such a test for Bacula then we can include it for
sure.


> Or, better yet, people writing code that is intended to be portable
> should write it in C or C++, rather than GCC or G++ or some other dialect.
>

Sure. If only we had one standard for C or C++ language. :)


>
> >     Also, the last line of src/filed/suspend.h does not have a newline,
> >
> >
> > Is it a real problem for SDS?
> >
> It's not a problem, it's just another pointless irritation.  Compilers
> should complain about mal-formed files, because they can't be sure they
> haven't been truncated by some error.
>

Sure. I do not deny it should and will be fixed, but I wonder if it was a
problem for SDS as it is not the only one file like this.

best regards
-- 
Radosław Korzeniewski
[email protected]

_______________________________________________
Bacula-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/bacula-devel