Re: xml list format

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hello Wesley,

Wesley Leggette wrote:
|
| I've implemented an xml listing mode for dar. (See patch).
|
|
http://sourceforge.net/tracker/index.php?func=detail&aid=1377733&group_id=65612&atid=511614
|
|
| I know that the API was frozen on 5 Dec, but I'm hoping that if you like
| this it could be fit in soon.

That's OK, the impact is not huge on the API, since this is only the
change of one argument's type (which argument keeps the same role) and
this in only one method.

I don't see much application on XML output provided by the patch. Could
you bring me some lights on theses? Thanks.

Next point, integrating your patch I found something strange, the
'action' field for a given inode has the value "add" if the data is
saved in the archive (I would rather chose "restore", because the
operation can also overwrite a file, not only add it, depending on the
switchs provided at restoration time, or maybe if we don't want to be
too restoration-related the "action" word is not the most suite, I would
suggest "state" or "data" with the values "saved", "not saved" ...)...
so, action is based on the inode data ("add" value), and also on the
Extended Attributes status, ("modified" value).

Extended Attributes and file data are not the same. First file data is
only possible with plain files, while EA are possible with any type of
inode (directories, symlinks ...).

My suggestion would be to replace "action" by two indicators:
- - "data" with "saved" / "identical" values for example
- - "EA" with "saved" / "identical" / "absent" values for examples.

What's your idea?

|
| Thanks,
| Wesley
|
|
|

Cheers,
Denis.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFDnayspC5CI8gYGlIRAk2/AKDKsXbf8cY8e85ckr1Etezbf1mfBQCgxnLD
SlfWwPzeHr4AWppoEa+YmGY=
=27v6
-----END PGP SIGNATURE-----



-------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc. Do you grep through log files
for problems?  Stop!  Download the new AJAX search engine that makes
searching your log files as easy as surfing the  web.  DOWNLOAD SPLUNK!
http://ads.osdn.com/?ad_id=7637&alloc_id=16865&op=click