Re: 2.5.14-bis exception on unsupported compression

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Hi


thank you for this feedback!

On 24/08/2018 07:48, mannino wrote:
> dar version from Ubuntu 18.04 packages when attempted to be used
> with an unsupported compression throws an exception during the
> cleanup:
> 
> Final memory cleanup... ---- exception type = [BUG] ---------- 
> [source] File wrapperlib.cpp line 337 : it seems to be a bug here

[...]

> 
> dar version 2.5.14-bis, Copyright (C) 2002-2052 Denis Corbin Long
> options support       : YES
> 
> Using libdar 5.12.1 built with compilation time options: Libz
> compression (gzip)      : YES Libbz2 compression (bzip2)   : YES 
> Liblzo2 compression (lzo)    : YES Liblzma compression (xz)     :
> NO     <<< NOTE THIS Strong encryption (libgcrypt): YES Public key
> ciphers (gpgme)   : YES Extended Attributes support  : YES Large
> files support (> 2GB)  : YES ext2fs NODUMP flag support   : YES 
> Special allocation scheme    : NO Integer size used            : 64
> bits Thread safe support          : YES Furtive read mode support
> : YES Linux ext2/3/4 FSA support   : YES Mac OS X HFS+ FSA support
> : NO Detected system/CPU endian   : little Posix fadvise support
> : YES Large dir. speed optimi.     : YES Timestamp read accuracy
> : 1 microsecond Timestamp write accuracy     : 1 microsecond 
> Restores dates of symlinks   : YES
> 
> compiled the Feb 17 2018 with GNUC version 7.3.0 dar is part of the
> Disk ARchive suite (Release 2.5.14-bis)
> 
> Command line:
> 
> dar -c ... -A... -@... -s... -zxz:6
> 
> When -zgzip:6 is used, it works fine. I'd expect a friendly error 
> telling compression method is unsupported (from -V) rather than an 
> exception.
> 
> Or is this an issue with the Ubuntu's package? (I don't currently 
> have access to another system to test it outside of Ubuntu.)
> 

this was no handling for that particular case (asking xz compression
while libxz is has not been linked with at compilation time), so libdar
hit a sanity check condition and triggered this error message.

2.6.0.RC2 is now available with fixes for that situation. I have also
checked for similar situation with other library libz, libbz2,
libcurl, libgpgme, and so on. Should be OK now.

I'm also working on the compilation problem under cygwin... keep you
informed.

Best Regards,
Denis

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIVAwUBW4EXkggxsL0D2LGCAQgf8Q/9H3YXA9ABjXMBea+HCG28h5pc/YGzaodc
QsPvJZrIsjXRlqxqAqXfjF+LqGfsRirudokRPCsoGfR36flgDsVg1pEFBLHnGUOW
LRx9fB3uzS6t+0fTZ7iXzFYdXCFKhemZ2M72IyOm+Wjc8haSB0JwSUwSk3IJICyN
V39jxOmJ1l9OZ1QnYZz6b1p68alV5gEwTMChAzbONOM3WoMldGlLr38OiMRCn9/Q
Vh8PIS/Jn0v0Pyx/ODY+GHpPwx7WiYyD5o4n9Jq13hFLxiWmGZjXHtUegCmeQFTn
DIhC2P6FGsy8+Po5UE+2eMi1sJPV/dMebLlN5Eu02uT1iDjWQH/0G32xfUHS390M
yTE/0h74g+90wzhNKO+CDqCgLIo8usiABDgeJcbck90G+XJUHg6HHCWir60My33A
OrY14FafC16SMqqEu1O8vgW6yEthQtG3srb7Kpw7lmX7tyBHBbp98xWalDAsiYZA
FouS8Qf3mDuR4hxf5fsCr3QqRjxvpeh7YCnnFZRK4VuJ2X10UppBuKudaHRWXli8
q9MoUdxcgGGoQsWinn8ShCTVJCf+ThnOFl3plsTwD/FjgaFKunoBkP5MZa67mXjc
Ij/xnpG1WH184bR7HqFjwYHoY6jflBrbMD/djrzauv8gjm4isA6W91ElyGqtBfPU
400Oqwr+UZY=
=espY
-----END PGP SIGNATURE-----

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot