Re: Binary delta in 2.6.0

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

On 13/01/2019 20:33, gulikoza via Dar-discussions wrote:
> Hi,

Hi,

> 
> 
> Thank you for pushing all the fixes.
> 
> Another observation, which I'm not sure if it's related...I'm
> getting a lot of notices in the log:
> 
> Failed resaving uncompressed the inode data ... Resaving
> uncompressed the inode data to gain space is not possible, keeping 
> data compressed ...
> 
> 
> A lot more than what was with version 2.5. Some files get the first
> warning, some files the second...I haven't really figured out why
> the messages are appearing and what is the difference between the
> two. Can this be related to delta signatures or might this be some
> other issue in 2.6?

Strange thing. Can you double check that you are using the same
compression masks (-Y, -Z options), the same --mincompr option and the
same compression algorithm?

There has been change only with lzo compression in 2.5.10 to match the
compression ratio used by lzop as described here:

http://dar.linux.free.fr/doc/FAQ.html#lzop_vs_dar

for the rest, 2.6.x use the same compression code as release 2.5.10
and above

You should not observe difference when doing full backup, though, when
doing a delta patch, dar tries to compress the delta patch (not the
binary signature which is usually much smaller). This may lead to the
phenomenon you observe which can be reduced by increasing --mincompr
option (but also impacts normal backup)

> 
>> From the code there doesn't seem to be anything terribly wrong
>> with the
> archive if this is hit, but it's still somewhat concerning when
> there are a lot of these Failed messages... especially when they
> didn't seem to appear before.

Yes, I understand this concern, we will look into this. Can you check
whether this concerns only delta patch operation done during
incremental/differential backup?

> 
> Thanks!
> 
> gulikoza
> 
> 

Regards,
Denis
-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEOzEprx3d76WjfYGPCDGwvQPYsYIFAlw8gx0ACgkQCDGwvQPY
sYIaBw//YfZTOcabfWAifE/rsKXIHwPUs/11LPLFWJvoj6JpLE2PzVWkDAaXGq5q
zj1Dvu5x77nSh+wxS/VRxOxdD/IfHN3XCw4ArloXrWZYPtE9lXyUnznZa5mFbaI/
EweOBAkWANXbiBXJA2fVu8QrLAdd7bMLBhBnSWLY+oLhLPLxytQoJkjfI19r41zx
mRwci9X7whPJsISgjv7XUTCgWhl/WIFBBBlcxt4bXlacFHxrR2PzIHKKqyo8qlKe
HWvrvQvagb9FtAsD8kodjzeNngn2CxHRMIPZVy9SHV5Vc6sB1dqEQ7E8UK6BIkNc
EsDQQSBl3c9LEp66lBWopNAyLi/+uHRLNhukbnBjOStZTOLJgVHqL62ghagxTAg6
Vcf2ZvUvupKiED1jg/8Rd+IsLMOMIu4ARV2VSZw0X0dkW9JB4NRaUyOTlXBOLlLD
YA7Jj/a3TYlvx7sNroBjivxwr6RkGJP3id1fdev3y3q6VajlsPUTg9xOVswdGgQR
YcXV2E5V21ZcSh8qmzg6hZAkB0OVqtBJJkooM5GZIUYLOY0kPzs3LtMsCO6ZCWj1
2eau/VVtYpKSA35ImuafXqxORCECugjF3dAGeWSJHjG3C3rBI9izY2NHlAM9NuLt
gOqKWze1pl3VuuqbbX2mMGzElOlrM7OMKqW8eWyty2NlRW4kzFI=
=cHim
-----END PGP SIGNATURE-----