Re: catalogue/directory: sorted set instead of vector

Denis Corbin <[email protected]> Mon, 07 Sep 2009 21:12:20 +0200
Newsgroups gmane.comp.sysutils.backup.dar.libdar
Message-ID <[email protected]>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

[email protected] wrote:
[...]

> [..]
>> Yes, I can imagine... There has been some feedback on that point some
>> time ago (that triggered the new implementation by the way).
> 
> Oh well, I searched the mailing lists but obviously not thoroughly enough ;)

As far as I remember it was on dar-support mailing-list, rawly six
months ago.

> 
> [..]
>> Thank you for your feedback Thomas. I do change the 2.3.x releases only
>> for bugs to keep it stable (OK, we could open a long discussion on the
>> fact that this problem is or not a bug. For me it is not, the software
>> does what it is expected to do, slowly, yes). Instead next to come 2.4.0
>> is still under heavy development, thus any change can be brought there
>> with much more ease.
> 
> Sure it's not really a bug. So I'll try to wait for the 2.4.0 release then.
> 
> Just in case that turns out to be too problematic and I would really
> need a working patch for the 2.3.X-branch before that:
> 
> If I would keep the current ordering in the vector<nomme*> fils and  
> additionally add a fast lookup datastructure, to increase the  
> insert/search speed, that should work with the rest of the code,  
> right?

This is what I have done in the current development version. By the way,
You can check that you do not forgot anything in your implementation by
having a look at the current code in CVS Trunk and searching where is
used the map<> data structure of the "directory" class. Maybe that will
help, even if your implementation is different.

> As all
> the data structures are private?

It should not be necessary (nor it is recommanded) to have it public or
just protected.

> 
> Of course this would require additional memory,
> but that's not normally an issue in my case.
> 
>     Thanks for the feedback,
>         Thomas
> 
> 

Regards,
Denis.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFKpVsUpC5CI8gYGlIRArbOAJ94ECGUYIUuITHu9OFxFATkFtEWqwCdGdTa
8QnPy4qXooOioQ2RCElYJ94=
=9S/Z
-----END PGP SIGNATURE-----

------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day 
trial. Simplify your report design, integration and deployment - and focus on 
what you do best, core application coding. Discover what's new with 
Crystal Reports now.  http://p.sf.net/sfu/bobj-july