Re: Announcing bglibs version 1.020

Gerrit Pape <[email protected]>
Newsgroups gmane.comp.sysutils.bgware
Message-ID <20050603163901.24089.qmail@b037baed93264c.315fe32.mid.smarden.org>
On Fri, May 27, 2005 at 10:31:45PM -0600, Bruce Guenter wrote:
> Version 1.020 of bglibs is now available at:
> 	http://untroubled.org/bglibs/

Hi, the selftests show some errors when building bglibs on Debian ppc,
s390, ia64, and alpha.  Thanks for the selftests by the way, I wish more
projects would include such kind of test suite.

On ppc and s390 str_catf() and str_copyf() fail, see

 http://buildd.debian.org/fetch.php?&pkg=bglibs&ver=1.020-2&arch=powerpc&stamp=1117794727&file=log&as=raw
 http://buildd.debian.org/fetch.php?&pkg=bglibs&ver=1.020-2&arch=s390&stamp=1117794582&file=log&as=raw

and below for a suggested patch.  On ia64 and alpha it's fmt_multi().

 http://buildd.debian.org/fetch.php?&pkg=bglibs&ver=1.020-2&arch=ia64&stamp=1117794998&file=log&as=raw
 http://buildd.debian.org/fetch.php?&pkg=bglibs&ver=1.020-2&arch=alpha&stamp=1117811175&file=log&as=raw

Regards, Gerrit.


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
str.diff (text/plain, 740 B)
diff -ur ../bglibs-1.020.old/str/catf.c str/catf.c
--- ../bglibs-1.020.old/str/catf.c	2005-05-27 23:41:10.000000000 +0000
+++ str/catf.c	2005-06-03 16:33:47.000000000 +0000
@@ -29,7 +29,7 @@
   if (!str_realloc(s, s->len + length))
     return 0;
 
-  fmt_multiv(s->s + s->len, format, ap);
+  fmt_multiv(s->s + s->len, format, ap2);
   va_end(ap2);
 
   s->s[s->len += length] = 0;
diff -ur ../bglibs-1.020.old/str/copyf.c str/copyf.c
--- ../bglibs-1.020.old/str/copyf.c	2005-05-27 23:41:10.000000000 +0000
+++ str/copyf.c	2005-06-03 16:33:47.000000000 +0000
@@ -29,7 +29,7 @@
   if (!str_ready(s, length))
     return 0;
 
-  fmt_multiv(s->s, format, ap);
+  fmt_multiv(s->s, format, ap2);
   va_end(ap2);
 
   s->s[s->len = length] = 0;
fmt.diff (text/plain, 525 B)
diff -ur ../bglibs-1.020.old/fmt/multi.c fmt/multi.c
--- ../bglibs-1.020.old/fmt/multi.c	2005-05-27 23:41:10.000000000 +0000
+++ fmt/multi.c	2005-06-03 16:33:47.000000000 +0000
@@ -172,10 +172,10 @@
     switch (conv) {
     case 'i': case 'd': case 'o': case 'u': case 'x': case 'X':
       value = islonglong
-	? va_arg(ap, unsigned long long)
+	? va_arg(ap, long long)
 	: islong
-	? va_arg(ap, unsigned long)
-	: va_arg(ap, unsigned);
+	? va_arg(ap, long)
+	: va_arg(ap, int);
     }
     switch (conv) {
     case 'i':
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.