Re: [Bug-dejagnu] [dejagnu patch] tweak conditional_xfail empty 'includes' list behaviour
Rob Savoye <[email protected]>
| Newsgroups | gmane.comp.gdb.patches,gmane.comp.sysutils.dejagnu.bugs |
|---|---|
| Message-ID | <[email protected]> |
On Wed, Apr 30, 2003 at 01:31:08PM -0700, [email protected] wrote: > I believe the change is fairly self-explanatory. The situation that > i'm trying to address is certain tests which should, say, be > conditionally-xfailed for certain MIPS targets, but only with certain > flags. [ ... ] > I believe that this should be a safe change in semantics, because an > empty includes list used to mean "the condition will never be true," > and, well, there's no point in doing the whole conditional xfail dance > if the condition will enver be true. 8-) Well, I'd think this patch is pretty much GCC testing specific, like most of the xfail support. If the GCC folks think it's ok, then I guess it's ok with me too. I just merged in your patch, and I'll test it some. But off the top of my head, it looks fine. I'll check it into the master sources on subversions after playing with it. - rob -