Re: BUG: improper format string construction in framework.exp

On Okt 28 2018, Jacob Bachmeyer <[email protected]> wrote:

> diff --git a/lib/framework.exp b/lib/framework.exp
> index 6cb93c5..50ac757 100644
> --- a/lib/framework.exp
> +++ b/lib/framework.exp
> @@ -800,7 +800,7 @@ proc record_test { type message args } {
>  
>      global multipass_name
>      if { $multipass_name != "" } {
> -       set message [format "$type: %s: $message" "$multipass_name"]
> +       set message [format "%s: %s: %s" "$type" "$multipass_name" "$message"]

What's the point of using format in the first place?

          set message "$type: $multipass_name: $message"

Andreas.

-- 
Andreas Schwab, SUSE Labs, [email protected]
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE  1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."