bug#53427: perror should not errcnt across test files

Martin Cermak <[email protected]> Fri, 21 Jan 2022 22:02:08 +0100
Newsgroups gmane.comp.sysutils.dejagnu.bugs
Message-ID <[email protected]>
--h5vzmhlgrta5clio
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

There seems to be an old bug originally reported in the Red Hat
bug tracker [1] still present in the dejagnu 1.6.3 sources.
Steps to Reproduce:


echo 'perror foo' >a.exp; echo 'pass bar' >b.exp; runtest a.exp b.exp; cat testrun.sum

Actual results:
...
Running target unix
Running ./a.exp ...
ERROR: foo
Running ./b.exp ...
UNRESOLVED: bar

                ===  Summary ===
...

Expected results:
...
Running target unix
Running ./a.exp ...
ERROR: foo
Running ./b.exp ...
PASS: bar

                ===  Summary ===
...


Patch attached.  Please consider fixing.

Thanks,
Martin



-------
[1] https://bugzilla.redhat.com/show_bug.cgi?id=460153


--h5vzmhlgrta5clio
Content-Type: text/plain; charset=us-ascii
Content-Disposition: attachment;
 filename="dejagnu-1.6.3-perror-across-test-files.patch"

diff --git a/runtest.exp b/runtest.exp
index 4e4eb15..2a81830 100644
--- a/runtest.exp
+++ b/runtest.exp
@@ -1601,8 +1601,7 @@ proc runtest { test_file_name } {
     global testdir
 
     clone_output "Running $test_file_name ..."
-    set prms_id	0
-    set bug_id	0
+    reset_vars
     set test_result ""
 
     # set testdir so testsuite file -test has a starting point

--h5vzmhlgrta5clio
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: base64
Content-Disposition: inline

X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KQnVnLWRlamFn
bnUgbWFpbGluZyBsaXN0CkJ1Zy1kZWphZ251QGdudS5vcmcKaHR0cHM6Ly9saXN0cy5nbnUub3Jn
L21haWxtYW4vbGlzdGluZm8vYnVnLWRlamFnbnUK

--h5vzmhlgrta5clio--