patch #8947: Don't try to execute a data file
Ben Elliston <[email protected]>
| Newsgroups | gmane.comp.sysutils.dejagnu.general |
|---|---|
| Message-ID | <[email protected]> |
Hi Rob
I've just looked at your patch here:
https://savannah.gnu.org/patch/index.php?8947
This seems a bit odd to me:
+ # Don't try to execute a data file, which is used by some tests
+ # to compare output.
+ if {[regexp "^\.txt$" $prog]} {
+ return ""
+ }
Wouldn't it be better to not call unix_load with such an argument?
Also, the patch contains a proc definition called make_absolute. It's
redundant -- Tcl offers `file normalize'.
Cheers,
Ben
_______________________________________________
DejaGnu mailing list
[email protected]
https://lists.gnu.org/mailman/listinfo/dejagnu
signature.asc
(application/pgp-signature, 811 B)
-----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIVAwUBVvDw+nY2KIi1WYjUAQgrCg/+Pw5e4OVtqWoP0ISgD47/r2sxxHRFzJ2C l/rj2Wp5CVyS6BWKYDmQRUy25m2TNI8IAJdfR6G5w3bDHXYo7Rj34CME4lNzrTTh 5kyYBK7BzwHctsAMyVAFUR8C7NWmkA7LQVWOZ0cGbrUaRYKz1sfPEvkZKguie2Aj /4NshZ02zwY82Zdn/xvBN1zNbpDAl0ox+Gf2EmOCn4LaMqqUO63ZCMC3wTHSinrb BLNFDFTPZGolViflPfdYHjBED7mNFjJXoEoRR3b1drPANw7XfnuJUAgV5Ex1jIww bgHvrsEsVUI92ZPjdgtTR9r9/g2AdRiGfwz2wjAPjP8Gv8VHQgVsGlCzxLCsH4eE T9XZR29k8KNR8A6LgUdhSgxM7RvRmotk8hYrfKl24RdqGsL7e8fEMIWNvczQRTg7 tGCbPTakfvPqXZMKKTJIaFdBjq+Hk90MT/pdTUPes7JxfKzhhM+iSK2ZmzJ/WpIN WWETWRELyn0b6gy831aCMC6hwIYYcgA69pkdoJpLTrwmSxfn6CI05ZxrOEjPx6m3 cWZirV16hx5BpI5nBiAFpH+Ep0jtpD0xyjkX7F+mQNL8f+3rH+++9h0XO8JV8zmO FTzmAYkNgcJn2SZuNNVn4EgCDuLnRH1NnPYZmsfq59bw/aWW6H5fVWinUsIfCAcc Go3Yoj3qnCs= =54AJ -----END PGP SIGNATURE-----