Re: [RFA] fix remote testing I/O conflicts

Yvan Roux <[email protected]>
Newsgroups gmane.comp.sysutils.dejagnu.general
Message-ID <CAD57uCffut-Rf2yBTZNnumabfBnRMFfm2uhhkRfeYv8srXF7zA@mail.gmail.com>
Hi Ben,

On 4 April 2016 at 10:16, Ben Elliston <[email protected]> wrote:
> Hi Yvan,
>
>>         * config/unix.exp (unix_load): Delegate remote directory handling to
>>         remote_download.
>>         * lib/remote.exp (remnote_download): Create a remote directory (in a
>>         new global remotedir) if needed and handle it.
>>         (remote_exec): Execute program inside remotedir when it exists.
>>         (remote_close): Remove remotedir when it exists.
>>         (standard_load): Delegate remote directory handling to
>>         remote_download.
>
> remotedir shouldn't be a global variabl. It needs to be a proper board
> setting -- please, no more globals! :-)

Oh ok ... it was a board setting in my first patch, maybe I
misunderstood the comments ;)

> Can you please fix the patch to do this?  Also, you need to make sure
> the documentation is updated with the new board setting so that people
> don't need to read the DejaGnu code to discover it.

Ok, sure.

Thanks
Yvan
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.