[PATCH, dejagnu] Log file renaming

Thomas Preudhomme <[email protected]>
Newsgroups gmane.comp.sysutils.dejagnu.general
Organization ARM
Message-ID <[email protected]>
Hi,

One confusing thing for people new to GCC trying to reproduce a
testcase failure for arm-none-eabi targets is the origin of the
gcc_tg.o file linked in all execution testcases. It cannot be found in
the build tree and there is no mention of its building in the log file.
As mentioned in [1], it's gcc-testglue.o renamed and the log do mention
how to build that file. However, the renaming itself is not logged.

[1] https://gcc.gnu.org/ml/gcc/2013-10/msg00246.html

This patch adds a logging message to the remote_download procedure in
dejagnu so that people can see the origin of files which are downloaded
or renamed.

ChangeLog entry is as follows:

2017-03-03  Thomas Preud'homme  <[email protected]>

         * lib/remote.exp (remote_download): Add logging message when source
         and destination file differ in name.


Running GCC testsuite with this patch shows the expected message in the log.

Best regards,

Thomas

_______________________________________________
DejaGnu mailing list
[email protected]
https://lists.gnu.org/mailman/listinfo/dejagnu
log_file_renaming.patch (text/x-patch, 521 B)
diff --git a/lib/remote.exp b/lib/remote.exp
index f2c634564d03e19a6be9bea9996d22a0a3ab7b9a..4dd6a8a638422df3a04fef1428573e695bff936b 100644
--- a/lib/remote.exp
+++ b/lib/remote.exp
@@ -440,6 +440,7 @@ proc remote_download { dest file args } {
 	if { $destfile == "" || $destfile == $file } {
 	    return $file
 	} else {
+	    verbose -log "Downloading on $dest to $destfile: $file" 2
 	    set result [catch "exec cp -p $file $destfile" output]
 	    if {[regexp "same file|are identical" $output]} {
 		set result 0
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.