Re: PATCH: add relative_file_name procedure to encapsulate logic for "subdir" variable [revised]
Jacob Bachmeyer <[email protected]>
| Newsgroups | gmane.comp.sysutils.dejagnu.general |
|---|---|
| Message-ID | <[email protected]> |
Ben Elliston wrote:
> On Tue, Dec 04, 2018 at 12:10:53AM -0600, Jacob Bachmeyer wrote:
>
>> While the GNU Coding Standards suggest using "file name"
>> specifically; a quick grep shows that DejaGnu already has proc
>> unix_clean_filename and no procedures that use "file_name" in their
>> names, so consistency suggests that the change should be made. A
>> revised patch follows.
>>
>
> Thanks. One more request: can you please document this new proc in the
> NEWS file (along with --local/global_init)?
>
Here is a separate patch for the NEWS file:
----
diff --git a/NEWS b/NEWS
index cb8f01a..aed6a9b 100644
--- a/NEWS
+++ b/NEWS
@@ -5,6 +5,10 @@ Changes since 1.6.2:
1. The internal proc 'is_remote' has been renamed to 'isremote' for
consistency with the other similar procs (eg, istarget). Testsuites
should use this proc. The 'is_remote' proc is deprecated.
+2. runtest now accepts --local_init and --global_init options to override
+ the default of reading "site.exp". See the manual for details.
+3. A utility procedure relative_filename has been added. This procedure
+ computes a relative file name to a given destination from a given base.
Changes since 1.6.1:
----
-- Jacob