Re: PATCH: fix "missing tests" bug and other improvements to testsuite/runtest.all/libs.exp

On Sun, Dec 09, 2018 at 10:28:10PM -0600, Jacob Bachmeyer wrote:

> This patch fixes a bug that could cause test results to be missed in
> libs.exp and adds material to the manual explaining the issue.

Thanks. Applied.

> While adding an entire page worth of text to the manual may seem an
> unusual step in fixing a bug, I wrote it because I had previously
> hit the same bug in code that I had written for my own project's
> testsuite.  Finding that the same bug that had taken me a week to
> track down (because it was inconsistent, depending on the whim of
> the scheduler whether or not additional results would be in the
> Expect buffer) was also in DejaGnu's own testsuite prompted me to
> document this particular "gotcha" with Expect.

Much appreciated!

> 	* testsuite/runtest.all/*.test: Emit END markers when done.

I can't find the reference now, but I seem to recall the GNU coding
standard saying that ChangeLogs should not use wildcards because it
prevents searching for the particular filename later
(eg. "remote.test" would not be found in the ChangeLog entry above). I
have fixed this up for you.

Cheers, Ben

_______________________________________________
DejaGnu mailing list
[email protected]
https://lists.gnu.org/mailman/listinfo/dejagnu

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEFS8+rdM1/2KWERKFZ9rcPj90NkkFAlwOLVgACgkQZ9rcPj90
Nkk07Q/9HMU9wBLZVczIu2+roLivSyGyi8Y7JZD+QfUKKdd1RSNvKdD829eGpLnf
V3zVRNfpt3FXMZ/amk/JxwI6c8yiUty2/winBDAMV7Ynm03XrBXbew/rcDcu+Y0i
d0qq3IJ512ZjPscPtBlBBZIQ9dQe8kSOdlxC830cyhVZVFMyZVKMCuy9j+m0luZo
mnGk8CpEN8GqLHZgnoV1rtlb7GF5jRafzPBre5G1jRHr0JE1aIg6jCkokDOuwGh0
EqRKeYuOfr9BO+aCi0romMmS1U3HJ++NcArSdFmv1PcsjmaPoL7ibxQoApLKp6ih
QOlBnEirtnIkUkBDl+V0Ce28vwnal3CfXoMEd4GAwA7rNr+q78qbhnad4hCWK1oU
OG3EIOL4pWZX/utXo9lQ7ils8hAKfPikjplgAHw7cM8rkPqTVObGC52Yq5A1Kghi
xknKdOFogogEr6bnSK9dhwBGuG7hy49oe5NkCfq8pq/9lnIvtEXcs/Qa4fzgBZtA
HpJvlS4UbGjqm6YoMBW7LZvvCIdOMIsNxwu9S6loqT1TnweIXqeqIGiO4mX1vK6g
u+zSWIl/NaNK8JTaBIXue9wtw3Sgwk+QFXKT+vZxNjgmo+/bpwGRUrMEsllsEVrA
/R2yhOxKMdlgA2issNMvlvNTl8mX/UK7/nJyWy2SDcByysIPKEM=
=sGe5
-----END PGP SIGNATURE-----