Re: [PATCH 1/2] Use 'file join' to concatenate directory and filename
Jacob Bachmeyer <[email protected]>
| Newsgroups | gmane.comp.sysutils.dejagnu.general |
|---|---|
| Message-ID | <[email protected]> |
Andrew Burgess wrote: > In search_and_load_file in once place 'file join' is used to > concatenate a directory and a filename, while elsewhere in the > function the concatenate is hard coded as a string "$dir/$initfile", > assuming that '/' is used to join components. > > Presumably this is fine for all the targets dejagnu supports, but its > probably better to stick to one approach or the other. > > This patch makes use of 'file join' for building paths. > Thanks; that is one of the eventual minor cleanups that I have been doing as I can fit them in. While I doubt that DejaGnu will ever be ported to a system that does not use the POSIX file name convention, it is possible that Expect may eventually be so ported and, in any case, [file join] is more clear than concatenating strings. I suspect that [file join] did not exist in Tcl when DejaGnu was first written. -- Jacob