Re: [PATCH 0/4] Handle test execution timeout consistently across protocols
Jacob Bachmeyer <[email protected]> Tue, 12 Dec 2023 21:47:38 -0600
| Newsgroups | gmane.comp.sysutils.dejagnu.general |
|---|---|
| Message-ID | <[email protected]> |
Maciej W. Rozycki wrote:
> The intent is to avoid having to override the respective TCL procedures
> locally just to correct the timeout handling shortcomings in the versions
> shipped with DejaGNU.
>
Upstreaming changes like these is very important because monkeypatching
the framework is not and cannot be supported and may break in various
strange ways in the future.
> [...]
>
> A change for the timeout factor will follow. As it consists of a DejaGNU
> part and a GCC part I chose to send it separately so as not to cross-post
> this whole series between the DejaGNU and GCC mailing lists.
>
> Any questions, comments, or concerns? Otherwise please apply.
Patches 1, 2, and 3 applied as offered on branch mwr-patch-20231212.
Patch 4 has been revised and applied on the branch because the command
to be executed is free-form text while the timeout is a simple number;
the revised format ("Executing on MACHINE with timeout TIMEOUT:
COMMAND") is easier to reliably parse.
-- Jacob