Re: [PATCH 2/4] ssh.exp: do not use '&&' with 'XYZ${?}ZYX' logic
Joseph Myers <[email protected]> Wed, 25 Mar 2026 17:43:07 +0000 (UTC)
| Newsgroups | gmane.comp.sysutils.dejagnu.general |
|---|---|
| Message-ID | <[email protected]> |
This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. ---1152306461-557153676-1774460587=:1111207 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT On Wed, 25 Mar 2026, Andreas Schwab wrote: > On Mär 24 2026, Joseph Myers wrote: > > > program fails, the subsequent rm would prevent that from working by > > yielding the exit status from rm instead. > > Why does it need to use rm in the first place? That is the duty of the > "remote_file ... delete" command that is called afterwards. > > Without that rm, there is no need for the XYZ marker any more, since the > true exit code can be extracted from the return value. Patch 4 removes the rm. I don't know whether there are any sshd implementations in current use that fail to pass through the exit status, which would be another potential use for the XYZ marker; I haven't tried any larger refactoring to remove the XYZ logic. -- Joseph S. Myers [email protected] ---1152306461-557153676-1774460587=:1111207--