Branch PR44602 needs testing
Jacob Bachmeyer <[email protected]> Sat, 11 Jul 2026 20:14:36 -0500
| Newsgroups | gmane.comp.sysutils.dejagnu.general |
|---|---|
| Message-ID | <[email protected]> |
This is a multi-part message in MIME format.
--------------N6q2LrVOKcaq9U4kmDNrmZEY
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Well, this is slightly embarrassing that getting to this took so long,
but the PR44602 branch should now fully resolve problems with whitespace
in file names, reported as debbugs #44602 as runtest failing to load
site.exp if the object directory absolute name contains whitespace.
Instead of a quick fix, I audited the codebase for similar issues where
catch(n) introduces additional interpolations. This should correct
problems with spaces in filenames generally, which are allowed in POSIX
but are not the traditional practice.
Some of the changes touch files for environments I do not have. Targets
using rsh, ssh, and adb should be tested before the PR44602 branch can
be merged to Git master.
If you have targets relying on config/adb.exp, lib/rsh.exp, or
lib/ssh.exp, please test the PR44602 branch. If I get no reports of
problems, I plan to merge it to master in about a week. If someone
needs more time to run tests, please ask on the list. After five years,
I am in no rush on this.
As a temporary measure,
sed -i -e '/set objdir/s/`pwd`/\\\"`pwd`\\\"/' Makefile
after running configure in a build directory with whitespace in its
absolute name will cause a correct site.exp to be produced for `make
check`. I have yet to investigate whether a newer Automake fixes this
issue or if I will also need to send a patch to Automake.
-- Jacob
--------------N6q2LrVOKcaq9U4kmDNrmZEY
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: 8bit
<!DOCTYPE html>
<html>
<head>
<meta http-equiv="content-type" content="text/html; charset=UTF-8">
</head>
<body>
<p>Well, this is slightly embarrassing that getting to this took so
long, but the PR44602 branch should now fully resolve problems
with whitespace in file names, reported as debbugs #44602 as
runtest failing to load site.exp if the object directory absolute
name contains whitespace.</p>
<p>Instead of a quick fix, I audited the codebase for similar issues
where catch(n) introduces additional interpolations. This should
correct problems with spaces in filenames generally, which are
allowed in POSIX but are not the traditional practice.</p>
<p>Some of the changes touch files for environments I do not have.
Targets using rsh, ssh, and adb should be tested before the
PR44602 branch can be merged to Git master.</p>
<p>If you have targets relying on config/adb.exp, lib/rsh.exp, or
lib/ssh.exp, please test the PR44602 branch. If I get no reports
of problems, I plan to merge it to master in about a week. If
someone needs more time to run tests, please ask on the list.
After five years, I am in no rush on this.</p>
<p>As a temporary measure, </p>
<blockquote>
<p>sed -i -e '/set objdir/s/`pwd`/\\\"`pwd`\\\"/' Makefile</p>
</blockquote>
<p>after running configure in a build directory with whitespace in
its absolute name will cause a correct site.exp to be produced for
`make check`. I have yet to investigate whether a newer Automake
fixes this issue or if I will also need to send a patch to
Automake.</p>
<p><br>
</p>
<p>-- Jacob</p>
</body>
</html>
--------------N6q2LrVOKcaq9U4kmDNrmZEY--