Re: Debian package build fails due to duplicated svga driver in Makefile

On 10.03.2011 19:13, Dominique Dumont wrote:
> Hello
>
> I'm trying to update lcdproc debian package with lcdproc 0.5.4
>
> The package is built with
> $ ./configure --enable-drivers=all
>
> This results in a DRIVERS list with duplicated svga.so in Makefile:
>
> $ grep svga Makefile
> DRIVERS =  bayrad.so CFontz.so CFontz633.so CFontzPacket.so curses.so CwLnx.so 
> ea65.so EyeboxOne.so g15.so glk.so hd44780.so i2500vfd.so icp_a106.so imon.so 
> imonlcd.so IOWarrior.so irtrans.so joy.so lb216.so lcdm001.so lcterm.so 
> lirc.so lis.so MD8800.so ms6931.so mtc_s16209x.so MtxOrb.so NoritakeVFD.so 
> picolcd.so pyramid.so sed1330.so sed1520.so serialPOS.so serialVFD.so 
> shuttleVFD.so sli.so stv5730.so SureElec.so svga.so svga.so t6963.so text.so 
> tyan.so ula200.so xosd.so
>
> Unfortunately, this also leads to duplicated install where the 2nd 
> installation of svga.so fails because the first one cannot be clobbered:
>
>   /usr/bin/install -c bayrad.so CFontz.so CFontz633.so CFontzPacket.so 
> curses.so CwLnx.so ea65.so EyeboxOne.so g15.so glk.so hd44780.so i2500vfd.so 
> icp_a106.so imon.so imonlcd.so IOWarrior.so irtrans.so joy.so lb216.so 
> lcdm001.so lcterm.so lirc.so lis.so MD8800.so ms6931.so mtc_s16209x.so 
> MtxOrb.so NoritakeVFD.so picolcd.so pyramid.so sed1330.so sed1520.so 
> serialPOS.so serialVFD.so shuttleVFD.so sli.so stv5730.so SureElec.so svga.so 
> svga.so t6963.so text.so tyan.so ula200.so xosd.so '/home/domi/debian-
> dev/lcdproc-0.5.4/debian/tmp/usr/lib/lcdproc'
> /usr/bin/install: will not overwrite just-created `/home/domi/debian-
> dev/lcdproc-0.5.4/debian/tmp/usr/lib/lcdproc/svga.so' with `svga.so'
>
> I do not know autoconf autotools enough to fix this. 
>
> Can somebody suggest a patch or even better, fix this upstream?
>
> All the best
>
> Dominique

Hi,

thanks for spotting this. Seems like nobody has build LCDproc with
svgalib installed for years (that section of the Makefile has not been
touch at least since 0.5.2).

Source of the problem is the check for headers in acinclude.m4:

        svga)
            AC_CHECK_HEADERS([vga.h vgagl.h],[
                AC_CHECK_LIB(vga, main,[
                    LIBSVGA="-lvga -lvgagl"
                    DRIVERS="$DRIVERS svga${SO}"
                    actdrivers=["$actdrivers svga"]
                ],[
dnl                else
                    AC_MSG_WARN([The svga driver needs the vga library])
                ])
            ],[
dnl            else
                AC_MSG_WARN([The svga driver needs vga.h and vgagl.h])
            ])
            ;;

Because AC_CHECK_HEADERS checks for two headers, action if found is run
two times, thus the driver is added two times.

It should be easy to fix - if someone has an immediate idea, please come up!

Regards,
Markus