Re: [Patch] Reducing header inclusions
Yura Scheglyuk <[email protected]>
| Newsgroups | gmane.comp.sysutils.lcdproc |
|---|---|
| Message-ID | <[email protected]> |
Hi! On 19.03.2011 5:29, Markus Dolze wrote: > attached is a patch I will commit soon that reduces a number of header include statements, mostly for drivers. Especially: > > * Do not include system headers in our own headers from 'shared/' > * Remove syslog.h from all drivers > * Remove fcntl.h and termios.h where not needed (e.h. libusb-based drivers) > * Remove lcd.h from headers where is was already included in .c > * Include<poll.h> instead of<sys/poll.h> > * Better check for<time.h> together with<sys/time.h> > * For hd44780 include "hd44780-low.h" in .c file instead of buried in the header file I tested imon and imonlcd on Ubintu 10.10 kernel 2.6.35. All working as usual. -- Best regards, Yura Scheglyuk.