Re: ethlcd driver improvements

On 13.03.2011 11:20, Mariusz Bialonczyk wrote:
> Hello
> I am sending some driver improvements:
> - added helper function for sending data
> - checking for correct device response
> - added timeouts for socket (fixes LCDd hang up eg. when device disappear)
>
> Please commit if you don't have objections.
>
> best regards,
>

Hi,

I had a look at this.

The only thing I'm vary about is if exiting is correct.

There is no way for a driver to signal the core to exit once the driver
is running, so using exit() is the only option if you want to quit LCDd.
However no cleanup of memory is performed then.

What may be reasons why a send / receive fails? If it is the TCP
connection that broke maybe reconnecting may be an idea?

Not related to you patch: If your ethlcd device can handle more than one
byte of input you may take advantage of the small flush buffer available
now. Have a look at hd44780-lcd2usb.c on how to make use of it.

Regards,
Markus