Re: imonlcd: spinning disc and progess bars

The change between 0.5.3 and 0.5.4 fixed a serious bug where the  
driver would continuously send commands to update the display icons,  
even when there were no changes needed.  As a result of this bug, I  
experienced display instability.  Your patch re-introduces the bug.   
I have not noticed the 1 second delay you mention. However, I can see  
in the code where it only updates the bars when there is an output  
command made by the client.  As a result, it skips an opportunity to  
update the spinning disc.  This change should be relatively simple to  
implement.  I will make a patch.
In the mean time, you might want to check what is going on with your  
configuration that is causing 1 second delay to update the icons.   
what kind of computer are you using?  Have you made configuration  
changes to slow down LCDproc?

--Eric

On Apr 20, 2011, at 2:29 PM, Karsten A. M. Günther wrote:

> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Hello lcdproc'ers,
>
> I would like to ask you a question regarding lcdproc 0.5.4 and the
> imonlcd driver. I am working on a patch for XBMC media center for full
> icon support in combination with Soundgraph's IMON LCD display and
> lcdproc (http://trac.xbmc.org/ticket/8981). In fact, it is working  
> quite
> fine, but since lcdproc 0.5.4 there is an issue regarding the spinning
> disc animation. Everytime, the progress bars are updated, the  
> animation
> stops for a short moment until the icons are updated again. I wrote  
> the
> attached perl script to verify this. This script executed with lcdproc
> 0.5.3 shows the spinning disc and a second later all progress bars and
> lines. The disc keeps spinning as expected. With lcdproc 0.5.4 the  
> disc
> starts spinning, after a seconds it stops and the progress bars  
> come up
> and after another second it starts spinning again.
>
> For my needs I reverted some changes in imonlcd.c, see attached  
> patch file.
>
> My question: am I doing or understanding something wrong or is this  
> just
> a bug in the code cleanup and rework you did in imonlcd.c between  
> 0.5.3
> and 0.5.4?
>
> Best regards,
> Karsten Guenther
>
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.10 (GNU/Linux)
> Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
>
> iQEcBAEBAgAGBQJNr1A1AAoJEGeYm4AaNYHY1i4IAIDnk2KjUrIrq0363R3Kmez0
> nIJKlGbZNepvISGK1ATpnPd14HCDfbDo0UJi1PPc4PMZsDJ0XkJoOd4sVTrKLyxr
> unFQGBOxJFUBFXUUTvjjQG9mTZsrdAZagHmskt9C0oPBGZGJeCeu4JQUiegr3OvK
> zBAgQi0ms3Fx3kcSjQQmMZ9/GjXOSMGl4mJ0gB9g+Us5GWg3eC3w8+mq0FeXWdYU
> YFGD8a45kHxUDRM3PLv3vbWXB81D3hwyYaTzpEwSoGjmxJqvCLXIxtuwr1nHLfFw
> fEsprXN75kvOc9Jt9Z6odx+XWzZEGrlHRI2wF593BR3vpb2lWoyppP5agFPWeX8=
> =hzqM
> -----END PGP SIGNATURE----- 
> <imon_disc_and_progress.pl><imonlcd.c.diff>___________________________ 
> ____________________
> LCDproc mailing list
> [email protected]
> http://lists.omnipotent.net/mailman/listinfo/lcdproc